public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add splash screen support via loading from flash
Date: Tue, 04 Jun 2013 17:08:11 +0200	[thread overview]
Message-ID: <51AE02DB.3000205@denx.de> (raw)
In-Reply-To: <CAMDMJ5PVwqvdi--Q8vX=+5z8g0NbbNf7KLJefvpPdK74+a7DHA@mail.gmail.com>

Hi Robert,

On 04/06/2013 16:57, Robert Winkler wrote:

> Yes, as Eric mentioned I submitted a patch yesterday which fixes
> splash screen prepare not working
> with CONFIG_VIDEO and will submit a separate patch to add the function
> to nitrogen6x.c once that goes through.

Ok, understood.

> 
> The only difference is that we won't call it in board_video_skip in
> nitrogen6x.c, it'll be called in
> drv_video_init similar to the way it is called in lcd_logo from drv_lcd_init.
> 
> Another thing that Eric pointed out that is a difference between
> PREBOOT and SPLASH_SCREEN_PREPARE
> is the former will always run but the latter will only run if there's
> a display which is preferable.
> 
> If I had submitted the fix first instead of just working around the
> bug I would probably have saved
> some confusion.  Sorry about that.


No worry - thanks for explanation, now we have better understood the issue.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2013-06-04 15:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30 21:03 [U-Boot] [PATCH] Add splash screen support via loading from flash Robert Winkler
2013-05-30 23:32 ` Wolfgang Denk
2013-05-31  0:01   ` Robert Winkler
2013-05-31  7:49     ` Wolfgang Denk
2013-05-31 17:50       ` Robert Winkler
2013-06-03  7:44 ` Stefano Babic
2013-06-03 16:34   ` Robert Winkler
2013-06-04 13:44     ` Stefano Babic
2013-06-04 13:55       ` Eric Nelson
2013-06-04 14:15         ` Stefano Babic
2013-06-04 14:30           ` Eric Nelson
2013-06-04 14:57             ` Robert Winkler
2013-06-04 15:08               ` Stefano Babic [this message]
2013-06-04 15:05             ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51AE02DB.3000205@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox