public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mugunthan V N <mugunthanvnm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] net, cpsw: disable gigabit support through plattform data
Date: Tue, 4 Jun 2013 20:59:24 +0530	[thread overview]
Message-ID: <51AE07D4.8060507@ti.com> (raw)
In-Reply-To: <51AE0491.7020507@denx.de>

On 6/4/2013 8:45 PM, Heiko Schocher wrote:
> Hello Wolfgang,
>
> Am 04.06.2013 17:00, schrieb Wolfgang Denk:
>> Dear Heiko,
>>
>> In message <1370335914-14027-1-git-send-email-hs@denx.de> you wrote:
>>> add possibility to disable gigabit support through
>>> plattform data. Current boards should not be affected
>>> through this patch.
>> ...
>>> +		if (phy->speed == 1000) {
>>> +			if (priv->data.gigabit_en) {
>>> +				mac_control |= GIGABITEN;
>>> +			} else {
>>> +				/* Disable gigabit as it's non-functional */
>>> +				mac_control &= ~GIGABITEN;
>>> +				phy->speed = 100;
>> Is this reliable?  I mean, how do we know it's a 100 Mbps connection
>> (and not for example a 10 Mbs one) ?
Phy speed info will be read from phy status itself for configuring
mac ctrl reg.
> Indeed. Anyway, I have to check, if this patch is necessary, as Tom
> noted ...
>
> bye,
> Heiko
As Tom mentioned this patch is applicable only for initial samples
as there was a issue with Gig mode packet transfer.
Now there is no issue with having Gig enabled by default.

Regards
Mugunthan V N

  reply	other threads:[~2013-06-04 15:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-04  8:51 [U-Boot] net, cpsw: disable gigabit support through plattform data Heiko Schocher
2013-06-04 13:58 ` Tom Rini
2013-06-04 15:00 ` Wolfgang Denk
2013-06-04 15:15   ` Heiko Schocher
2013-06-04 15:29     ` Mugunthan V N [this message]
2013-06-05 10:44       ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51AE07D4.8060507@ti.com \
    --to=mugunthanvnm@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox