From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] input: fix unaligned access in key_matrix_decode_fdt()
Date: Tue, 04 Jun 2013 13:29:24 -0600 [thread overview]
Message-ID: <51AE4014.10808@wwwdotorg.org> (raw)
In-Reply-To: <1369248498-1799-1-git-send-email-swarren@wwwdotorg.org>
On 05/22/2013 12:48 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Initialized character arrays on the stack can cause gcc to emit code that
> performs unaligned accessess. Make the data static to avoid this.
>
> Note that the unaligned accesses are made when copying data to prefix[] on
> the stack from .rodata. By making the data static, the copy is completely
> avoided. All explicitly written code treats the data as u8[], so will never
> cause any unaligned accesses.
Tom, does this patch look good?
The discussion following it was unrelated to this patch, but rather
related to pre-processing of device-trees, so I don't think should
prevent this patch being merged.
next prev parent reply other threads:[~2013-06-04 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 18:48 [U-Boot] [PATCH] input: fix unaligned access in key_matrix_decode_fdt() Stephen Warren
2013-05-26 19:28 ` Simon Glass
2013-05-26 20:55 ` Wolfgang Denk
2013-05-26 21:29 ` Simon Glass
2013-05-28 4:07 ` Stephen Warren
2013-06-04 19:29 ` Stephen Warren [this message]
2013-06-05 12:34 ` [U-Boot] " Tom Rini
2013-06-06 14:47 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AE4014.10808@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox