From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mmc: Update "mmc->part_num" when performing a partition switch
Date: Tue, 04 Jun 2013 17:31:31 -0600 [thread overview]
Message-ID: <51AE78D3.7020405@wwwdotorg.org> (raw)
In-Reply-To: <CAOMZO5DJjPzBGTwm0JdDMq3t8r-q6XnDuYbTUhRRAmGHm8YpKw@mail.gmail.com>
On 06/04/2013 05:16 PM, Fabio Estevam wrote:
> On Tue, Jun 4, 2013 at 7:12 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>
>> static void fini_mmc_for_env(struct mmc *mmc)
>> {
>> #ifdef CONFIG_SYS_MMC_ENV_PART
>> - if (CONFIG_SYS_MMC_ENV_PART != mmc->part_num)
>> + if (mmc->part_num != orig_part_num)
>> mmc_switch_part(CONFIG_SYS_MMC_ENV_DEV,
>> - mmc->part_num);
>> + orig_part_num);
>
> If I keep the original 'mmc->part_num' here, then it works.
It doesn't "work", it just hides the problem. By passing mmc->part_num
here, you're passing the partition that's already/currently selected
rather than restoring the original value. Selecting it again is a no-op;
IIRC the MMC core explicitly checks for this condition and immediately
returns without touching the HW.
prev parent reply other threads:[~2013-06-04 23:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 19:17 [U-Boot] [PATCH v2] mmc: Update "mmc->part_num" when performing a partition switch Fabio Estevam
2013-06-04 19:21 ` Stephen Warren
2013-06-04 19:30 ` Fabio Estevam
2013-06-04 19:36 ` Stephen Warren
2013-06-04 20:45 ` Fabio Estevam
2013-06-04 22:12 ` Stephen Warren
2013-06-04 23:09 ` Fabio Estevam
2013-06-04 23:30 ` Stephen Warren
2013-06-04 23:48 ` Fabio Estevam
2013-06-04 23:16 ` Fabio Estevam
2013-06-04 23:31 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AE78D3.7020405@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox