public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fdt: remove unaligned access in fdt_fixup_ethernet()
Date: Tue, 04 Jun 2013 21:41:02 -0600	[thread overview]
Message-ID: <51AEB34E.2090900@wwwdotorg.org> (raw)
In-Reply-To: <1369713679-3256-1-git-send-email-swarren@wwwdotorg.org>

On 05/27/2013 10:01 PM, Stephen Warren wrote:
> Some ARM compilers may emit code that makes unaligned accesses when
> faced with constructs such as:
> 
> char mac[16] = "ethaddr";
> 
> Replace this with a strcpy() call instead to avoid this. strcpy() is
> used here, rather than replacing all usage of the mac variable with the
> string itself, since the loop itself sprintf()s to the variable each
> iteration, so strcpy() is doing basically the same thing.

Jerry, does this patch look good? This fixes a problem that prevents
U-Boot from booting a Linux kernel for some people. Thanks.

  parent reply	other threads:[~2013-06-05  3:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-28  4:01 [U-Boot] [PATCH] fdt: remove unaligned access in fdt_fixup_ethernet() Stephen Warren
2013-05-28  4:05 ` Michael Trimarchi
2013-05-28  4:16   ` Stephen Warren
2013-06-05  3:41 ` Stephen Warren [this message]
2013-06-07 18:19 ` [U-Boot] " Tom Rini
2013-06-12  1:55   ` Jerry Van Baren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51AEB34E.2090900@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox