From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 05 Jun 2013 16:26:51 +0200 Subject: [U-Boot] arm, arm335x: add watchdog support In-Reply-To: References: <1370336136-14238-1-git-send-email-hs@denx.de> <51AF4885.4090403@denx.de> Message-ID: <51AF4AAB.2020808@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Michael, Am 05.06.2013 16:21, schrieb Michael Trimarchi: > Hi > > On Jun 5, 2013 4:17 PM, "Heiko Schocher" > wrote: >> >> Hello Michael, >> >> Am 05.06.2013 15:31, schrieb Michael Trimarchi: >> > Hi >> > >> > On Jun 4, 2013 10:55 AM, "Heiko Schocher" >> wrote: >> >> >> >> Add TI OMAP 16xx & 24xx/34xx 32KHz (non-secure) watchdog support. >> >> >> >> Signed-off-by: Heiko Schocher >> >> >> Cc: Albert Aribaud >> >> >> Cc: Tom Rini >> >> >> --- >> >> arch/arm/include/asm/arch-am33xx/cpu.h | 20 ++++++ >> >> drivers/watchdog/Makefile | 1 + >> >> drivers/watchdog/omap_wdt.c | 115 +++++++++++++++++++++++++++++++++ >> >> 3 Dateien ge?ndert, 136 Zeilen hinzugef?gt(+) >> >> create mode 100644 drivers/watchdog/omap_wdt.c >> [...] >> >> diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c >> >> new file mode 100644 >> >> index 0000000..dc4df98 >> >> --- /dev/null >> >> +++ b/drivers/watchdog/omap_wdt.c >> >> @@ -0,0 +1,115 @@ >> [...] >> >> + /* wait for posted write to complete */ >> >> + while ((readl(&wdt->wdtwwps) & WDT_WWPS_PEND_WTGR)) >> >> + ; >> >> +} >> >> + >> > >> > I think that this patch has some problem because watchdog reset is in getc code. Did you try to paste very long string when it is enabled? You need to >> > avoid reset when it is not needed >> >> I think, I do not understand you ... this is for all watchdogs >> the case ... >> >> I currently pasted a 500 bytes long string, seeing no problems >> with the watchdog... >> > > OK, maybe was a problem of my version. I have done the same driver 2 month ago and tested on omap3. I optimize the watchdog reset using time delaying. > BTW if it works I have no other comments. Sorry for the noise Maybe you have a chance to try this patch on your hw? bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany