public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] vf610twr: Drop unneeded 'status' variable
Date: Thu, 06 Jun 2013 09:50:32 +0200	[thread overview]
Message-ID: <51B03F48.7000800@denx.de> (raw)
In-Reply-To: <1370468088-30369-1-git-send-email-festevam@gmail.com>

On 05/06/2013 23:34, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> No need to use the 'status' variable, so just remove it.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Drop status variable
> 
>  board/freescale/vf610twr/vf610twr.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/board/freescale/vf610twr/vf610twr.c b/board/freescale/vf610twr/vf610twr.c
> index 04fa882..f14df8b 100644
> --- a/board/freescale/vf610twr/vf610twr.c
> +++ b/board/freescale/vf610twr/vf610twr.c
> @@ -301,16 +301,13 @@ int board_mmc_init(bd_t *bis)
>  		NEW_PAD_CTRL(VF610_PAD_PTA28__ESDHC1_DAT2, ESDHC_PAD_CTRL),
>  		NEW_PAD_CTRL(VF610_PAD_PTA29__ESDHC1_DAT3, ESDHC_PAD_CTRL),
>  	};
> -	s32 status = 0;
>  
>  	esdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC_CLK);
>  
>  	imx_iomux_v3_setup_multiple_pads(
>  		esdhc1_pads, ARRAY_SIZE(esdhc1_pads));
>  
> -	status |= fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
> -
> -	return status;
> +	return fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
>  }
>  #endif
>  

Acked-by : Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  parent reply	other threads:[~2013-06-06  7:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-05 21:34 [U-Boot] [PATCH v2] vf610twr: Drop unneeded 'status' variable Fabio Estevam
2013-06-05 21:43 ` Otavio Salvador
2013-06-06  7:50 ` Stefano Babic [this message]
2013-06-06 15:53   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B03F48.7000800@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox