From: Lubomir Popov <lpopov@mm-sol.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] OMAP5: Fix bug in omap5_es1_prcm struct
Date: Thu, 06 Jun 2013 12:02:31 +0300 [thread overview]
Message-ID: <51B05027.4040903@mm-sol.com> (raw)
In-Reply-To: <a837b6fdb7af1674ffee3cf0bd05ca64.squirrel@www.mm-sol.com>
Hi Tom,
On 26/05/13 23:03, Lubomir Popov wrote:
> The newly introduced function setup_warmreset_time(), called
> from within prcm_init(), tries to write to the prm_rsttime
> OMAP5 register. The struct member holding this register's
> address is however initialized for OMAP5 ES2.0 only. On ES1.0
> devices this uninitialized value causes a second (warm) reset
> at startup.
>
> Add .prm_rsttime address init to the ES1.0 struct.
>
> Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>
> ---
> V2 gives the correct prm_rsttime reg address for ES1.0. Copy-paste
> from ES2.0 in V1, sorry.
>
> arch/arm/cpu/armv7/omap5/prcm-regs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/cpu/armv7/omap5/prcm-regs.c b/arch/arm/cpu/armv7/omap5/prcm-regs.c
> index e9f6a32..f29ac77 100644
> --- a/arch/arm/cpu/armv7/omap5/prcm-regs.c
> +++ b/arch/arm/cpu/armv7/omap5/prcm-regs.c
> @@ -298,6 +298,7 @@ struct prcm_regs const omap5_es1_prcm = {
> .cm_wkupaon_io_srcomp_clkctrl = 0x4ae07898,
> .prm_rstctrl = 0x4ae07b00,
> .prm_rstst = 0x4ae07b04,
> + .prm_rsttime = 0x4ae07b08,
> .prm_vc_val_bypass = 0x4ae07ba0,
> .prm_vc_cfg_i2c_mode = 0x4ae07bb4,
> .prm_vc_cfg_i2c_clk = 0x4ae07bb8,
>
Could you please apply http://patchwork.ozlabs.org/patch/246454/
to the ti tree? This is the only obstacle for my board to boot
normally with a clean u-boot-ti in respect to the OMAP5 common
stuff.
Thanks,
Lubo
prev parent reply other threads:[~2013-06-06 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 20:03 [U-Boot] [PATCH v2] OMAP5: Fix bug in omap5_es1_prcm struct Lubomir Popov
2013-05-28 21:03 ` Tom Rini
2013-06-06 9:02 ` Lubomir Popov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B05027.4040903@mm-sol.com \
--to=lpopov@mm-sol.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox