[U-Boot] [PATCH v2] vf610twr: Drop unneeded 'status' variable

[U-Boot] [PATCH v2] vf610twr: Drop unneeded 'status' variable

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

No need to use the 'status' variable, so just remove it.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Drop status variable

 board/freescale/vf610twr/vf610twr.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/board/freescale/vf610twr/vf610twr.c b/board/freescale/vf610twr/vf610twr.c
index 04fa882..f14df8b 100644
--- a/board/freescale/vf610twr/vf610twr.c
+++ b/board/freescale/vf610twr/vf610twr.c
@@ -301,16 +301,13 @@ int board_mmc_init(bd_t *bis)
 		NEW_PAD_CTRL(VF610_PAD_PTA28__ESDHC1_DAT2, ESDHC_PAD_CTRL),
 		NEW_PAD_CTRL(VF610_PAD_PTA29__ESDHC1_DAT3, ESDHC_PAD_CTRL),
 	};
-	s32 status = 0;
 
 	esdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC_CLK);
 
 	imx_iomux_v3_setup_multiple_pads(
 		esdhc1_pads, ARRAY_SIZE(esdhc1_pads));
 
-	status |= fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
-
-	return status;
+	return fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
 }
 #endif
 
-- 
1.8.1.2

[U-Boot] [PATCH v2] vf610twr: Drop unneeded 'status' variable

[Otavio Salvador]

On Wed, Jun 5, 2013 at 6:34 PM, Fabio Estevam <festevam@gmail.com> wrote:

> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> No need to use the 'status' variable, so just remove it.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>

Reviewed-by: Otavio Salvador <otavio@ossystems.com.br>

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

[U-Boot] [PATCH v2] vf610twr: Drop unneeded 'status' variable

[Stefano Babic]

On 05/06/2013 23:34, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> No need to use the 'status' variable, so just remove it.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Drop status variable
> 
>  board/freescale/vf610twr/vf610twr.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/board/freescale/vf610twr/vf610twr.c b/board/freescale/vf610twr/vf610twr.c
> index 04fa882..f14df8b 100644
> --- a/board/freescale/vf610twr/vf610twr.c
> +++ b/board/freescale/vf610twr/vf610twr.c
> @@ -301,16 +301,13 @@ int board_mmc_init(bd_t *bis)
>  		NEW_PAD_CTRL(VF610_PAD_PTA28__ESDHC1_DAT2, ESDHC_PAD_CTRL),
>  		NEW_PAD_CTRL(VF610_PAD_PTA29__ESDHC1_DAT3, ESDHC_PAD_CTRL),
>  	};
> -	s32 status = 0;
>  
>  	esdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC_CLK);
>  
>  	imx_iomux_v3_setup_multiple_pads(
>  		esdhc1_pads, ARRAY_SIZE(esdhc1_pads));
>  
> -	status |= fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
> -
> -	return status;
> +	return fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
>  }
>  #endif
>  

Acked-by : Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[U-Boot] [PATCH v2] vf610twr: Drop unneeded 'status' variable

[Stefano Babic]

On 06/06/2013 09:50, Stefano Babic wrote:
> On 05/06/2013 23:34, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> No need to use the 'status' variable, so just remove it.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================