public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] arm: dra7xx: Update the EXTRA_ENV_SETTINGS
Date: Thu, 6 Jun 2013 11:18:02 -0500	[thread overview]
Message-ID: <51B0B63A.7090003@ti.com> (raw)
In-Reply-To: <20130606153144.GC10720@bill-the-cat>

On 06/06/2013 10:31 AM, Tom Rini wrote:
> On Wed, Jun 05, 2013 at 09:39:47AM -0500, Dan Murphy wrote:
>> Update the EXTRA_ENV_SETTING for the dra7xx.
>> The console needs to be set to ttyO0 and the
>> findfdt needs to be updated to load the
>> dra7xx-evm.dtb file.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> Did you run-time test this?  I'm a little concerned about the include
> order, but that might turn out alright.  But I think:
I compile and boot tested this on OMAP5.
>
>> +		"if test -z ${fdtfile}; then " \
> Really needs to be:
> if test -z "${fdtfile}"; then...
>
> So that it doesn't become:
> if test -z; then
> when fdtfile isn't set and we get a parse error there.
>
> Thanks!
>
OK I will update again once I get other comments.  Although I am not sure why we really need to protect someone putting the wrong uBoot on their device unless
we have a single uboot for all devices.  I think we are being over protective here.

-- 
------------------
Dan Murphy

  reply	other threads:[~2013-06-06 16:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-05 14:39 [U-Boot] [PATCH v3] arm: dra7xx: Update the EXTRA_ENV_SETTINGS Dan Murphy
2013-06-06 15:31 ` Tom Rini
2013-06-06 16:18   ` Dan Murphy [this message]
2013-06-06 16:20     ` Tom Rini
2013-06-06 16:24       ` Dan Murphy
2013-06-06 18:02         ` Dan Murphy
2013-06-06 18:26           ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B0B63A.7090003@ti.com \
    --to=dmurphy@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox