[U-Boot] [PATCH v3] arm: dra7xx: Update the EXTRA_ENV_SETTINGS

Dan Murphy
2013-06-06T16:18:02Z

On 06/06/2013 10:31 AM, Tom Rini wrote:
> On Wed, Jun 05, 2013 at 09:39:47AM -0500, Dan Murphy wrote:
>> Update the EXTRA_ENV_SETTING for the dra7xx.
>> The console needs to be set to ttyO0 and the
>> findfdt needs to be updated to load the
>> dra7xx-evm.dtb file.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> Did you run-time test this? I'm a little concerned about the include
> order, but that might turn out alright. But I think:
I compile and boot tested this on OMAP5.
>
>> + "if test -z ${fdtfile}; then " \
> Really needs to be:
> if test -z "${fdtfile}"; then...
>
> So that it doesn't become:
> if test -z; then
> when fdtfile isn't set and we get a parse error there.
>
> Thanks!
>
OK I will update again once I get other comments. Although I am not sure why we really need to protect someone putting the wrong uBoot on their device unless
we have a single uboot for all devices. I think we are being over protective here.

--
------------------
Dan Murphy