From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Trimarchi Date: Sun, 09 Jun 2013 23:01:42 +0200 Subject: [U-Boot] [PATCH v3] usb: omap: ulpi: fix ulpi transceiver access In-Reply-To: <201306092205.03509.marex@denx.de> References: <20130606144836.GA9769@panicking> <201306092205.03509.marex@denx.de> Message-ID: <51B4ED36.7050301@amarulasolutions.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Marek On 06/09/2013 10:05 PM, Marek Vasut wrote: > Dear Michael Trimarchi, > >> This patch fix the omap access to the transceiver >> configuration registers using the ulpi bus. As reported by >> the documentation the bit31 is used only to check if the >> transaction is done or still running and the reading and >> writing operation have different offset and have different >> values. What we need to do at the end of a transaction is >> leave the bus in done state. Anyway an error using the ulpi >> omap register is not recoverable so any error give out the >> usage of this interface. >> >> Signed-off-by: Michael Trimarchi >> Reviewed-by: Igor Grinberg > > Tom, can you ACK/NAK this ? I have no omap board. > I don't understand the point, the old code was wrong and you can check omap3/omap4 documentation. If you revert it you still have a wrong code so it's better to drop omap3/4 viewport. You can take a look at this patch http://git.omapzoom.org/?p=kernel/omap.git;a=commitdiff;h=2a18e1248588c326f0a63c5bce4a611d709130a8 that is used to fix this errata http://git.omapzoom.org/?p=kernel/omap.git;a=commitdiff;h=a0dd0ee69578e32f1469596b8fd3a6c8ef172d42 I'm using this ulpi code in one of our device. I have fixed the u-boot viewport code because I have seen it wrong. Sorry for the late response but I was busy for a Wedding ;), I can try to test it tomorrow on an omap3 device but I think that is more easy for Stefano because he has already a platform with a recent uboot > Best regards, > Marek Vasut > Michael