From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Trimarchi Date: Sun, 09 Jun 2013 23:37:29 +0200 Subject: [U-Boot] Please pull u-boot-ti/master In-Reply-To: References: <20130607191921.GM26693@bill-the-cat> Message-ID: <51B4F599.7030205@amarulasolutions.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi On 06/08/2013 10:43 PM, Lubomir Popov wrote: > Hi Tom, Michael, > >> Hello, >> >> The following changes since commit 3da0e5750b24a9491058df6126c7be577a276c09: >> >> arm: factorize relocate_code routine (2013-05-30 20:24:38 +0200) >> >> are available in the git repository at: >> >> git://git.denx.de/u-boot-ti.git master >> >> for you to fetch changes up to 80dd596d1b442ff53dbeb33eccdb8efd2283be79: >> > > [snip] > >> Michael Trimarchi (1): >> usb: omap: ulpi: fix ulpi transceiver access > > [snip] > >> drivers/usb/ulpi/omap-ulpi-viewport.c | 40 +- > > [snip] > > I just made a clean clone of u-boot-ti/master, manually applied the > changes to the ehci files, added my board files and made a build. > Everything seems to work fine, but I see an error message regarding > ULPI reset that was not present before, and obviously it is due to > Michael's changes: > > SOM5_EVB # usb start > (Re)start USB... > USB0: ULPI: ulpi_reset: failed writing reset bit Let me understand. The patch is wrong because you have a problem now. The old code was not sending any write command so any ulpi_reset and the test condition was wrong. > USB EHCI 1.00 > scanning bus 0 for devices... 6 USB Device(s) found > scanning usb for storage devices... 3 Storage Device(s) found > scanning usb for ethernet devices... 1 Ethernet Device(s) found > SOM5_EVB # usb tree > USB device tree: > 1 Hub (480 Mb/s, 0mA) > | u-boot EHCI Host Controller > | > +-2 Mass Storage (480 Mb/s, 200mA) > | FSC MEMORYBIRD USB2 C157040817120315AA > | > +-3 Hub (480 Mb/s, 2mA) > | | > | +-4 Mass Storage (480 Mb/s, 96mA) > | | Generic Ultra Fast Media Reader 000000264001 > | | > | +-5 Mass Storage (480 Mb/s, 100mA) > | USB Flash Drive 531C43B21928F11F > | > +-6 Vendor specific (480 Mb/s, 500mA) > > SOM5_EVB # > > Otherwise everything is OK, the device on the ULPI port is working > (it is #2 above). It is now late and I shall investigate in detail > tomorrow, this is just an early warning ;) Can you test the attach patch? Yes I know it is not inline but I will send inline tomorrow and I have done changing the old one. I was thinking port number was starting from 1 but I have done a quick check on soft_reset of omap and it is starting from 0 Michael > > Best regards, > Lubo > -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-OMAP-ULPI-This-patch-fix-the-omap-access-to-the.patch Type: text/x-patch Size: 3217 bytes Desc: not available URL: