From: Nikita Kiryanov <nikita@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] video:lcd:cfb_console: cm_t35: Add CONFIG_SPLASH_SCREEN_PREPARE support to CONFIG_VIDEO
Date: Mon, 10 Jun 2013 10:02:27 +0300 [thread overview]
Message-ID: <51B57A03.7020600@compulab.co.il> (raw)
In-Reply-To: <CAMDMJ5P5PBL2UobfdM4VSOoMfXcF41nVxSDFOUaAPx9csfMZqg@mail.gmail.com>
On 06/06/2013 10:06 PM, Robert Winkler wrote:
> One other unrelated question for Nikita from his splash prepare patch.
> Why did you use gd->fb_base when the global lcd_base is used
> elsewhere
> in the function and lcd.c in general. It seems inconsistent.
>
> 1094 if (splash_screen_prepare())
> 1095 return (void *)gd->fb_base;
>
I really don't remember anymore, but it was probably a refactoring
oversight or something similarly insignificant.
The two are equivalent, so feel free to change it to lcd_base to make
it more consistent with the rest of the code.
>> --
>> Regards,
>> Igor.
>
>
> Please advise,
>
> Robert
>
--
Regards,
Nikita.
prev parent reply other threads:[~2013-06-10 7:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 17:20 [U-Boot] [PATCH] video:lcd:cfb_console: cm_t35: Add CONFIG_SPLASH_SCREEN_PREPARE support to CONFIG_VIDEO Robert Winkler
2013-06-04 6:10 ` Igor Grinberg
2013-06-04 15:10 ` Robert Winkler
2013-06-04 18:11 ` Robert Winkler
2013-06-05 8:31 ` Igor Grinberg
2013-06-06 19:06 ` Robert Winkler
2013-06-09 7:35 ` Igor Grinberg
2013-06-10 7:02 ` Nikita Kiryanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B57A03.7020600@compulab.co.il \
--to=nikita@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox