From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nikita Kiryanov <nikita@compulab.co.il>
Date: Mon, 10 Jun 2013 10:02:27 +0300
Subject: [U-Boot] [PATCH] video:lcd:cfb_console: cm_t35: Add
 CONFIG_SPLASH_SCREEN_PREPARE support to CONFIG_VIDEO
In-Reply-To: <CAMDMJ5P5PBL2UobfdM4VSOoMfXcF41nVxSDFOUaAPx9csfMZqg@mail.gmail.com>
References: <1370280058-15835-1-git-send-email-robert.winkler@boundarydevices.com>
	<51AD84D2.1020805@compulab.co.il>
	<CAMDMJ5Nf_MsoqRHeg2R-Sj3Vzie9FXMs-L_Ta72r-fwBN-kh6Q@mail.gmail.com>
	<CAMDMJ5Pr_qC76-50QDMHApFfwPwwLNadgseR1fYS39y98AEvhQ@mail.gmail.com>
	<51AEF76C.5050503@compulab.co.il>
	<CAMDMJ5P5PBL2UobfdM4VSOoMfXcF41nVxSDFOUaAPx9csfMZqg@mail.gmail.com>
Message-ID: <51B57A03.7020600@compulab.co.il>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 06/06/2013 10:06 PM, Robert Winkler wrote:
> One other unrelated question for Nikita from his splash prepare patch.
>   Why did you use gd->fb_base when the global lcd_base is used
> elsewhere
> in the function and lcd.c in general.  It seems inconsistent.
>
> 1094        if (splash_screen_prepare())
> 1095            return (void *)gd->fb_base;
>

I really don't remember anymore, but it was probably a refactoring
oversight or something similarly insignificant.
The two are equivalent, so feel free to change it to lcd_base to make
it more consistent with the rest of the code.

>> --
>> Regards,
>> Igor.
>
>
> Please advise,
>
> Robert
>


-- 
Regards,
Nikita.