From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Tue, 11 Jun 2013 21:55:22 -0400 Subject: [U-Boot] fdt: remove unaligned access in fdt_fixup_ethernet() In-Reply-To: <20130607181909.GF26693@bill-the-cat> References: <1369713679-3256-1-git-send-email-swarren@wwwdotorg.org> <20130607181909.GF26693@bill-the-cat> Message-ID: <51B7D50A.3030307@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stephen, Sorry for not applying this in a timely manner. Thanks, Tom, for covering for me. gvb On 06/07/2013 02:19 PM, Tom Rini wrote: > On Mon, May 27, 2013 at 06:01:19PM -0000, Stephen Warren wrote: > >> Some ARM compilers may emit code that makes unaligned accesses when >> faced with constructs such as: >> >> char mac[16] = "ethaddr"; >> >> Replace this with a strcpy() call instead to avoid this. strcpy() is >> used here, rather than replacing all usage of the mac variable with the >> string itself, since the loop itself sprintf()s to the variable each >> iteration, so strcpy() is doing basically the same thing. >> >> Reported-by: Florian Meier >> Signed-off-by: Stephen Warren > > Applied to u-boot/master, thanks!