From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] dfu: make data buffer size configurable
Date: Wed, 12 Jun 2013 10:49:22 +0200 [thread overview]
Message-ID: <51B83612.9040009@denx.de> (raw)
In-Reply-To: <201306121036.03661.marex@denx.de>
Hello Marek,
Am 12.06.2013 10:36, schrieb Marek Vasut:
> Dear Tom Rini,
>
>> On Mon, Jun 10, 2013 at 09:05:48AM +0200, Wolfgang Denk wrote:
>>> Dear Heiko Schocher,
>>>
>>> In message <51B555D7.5010001@denx.de> you wrote:
>>>> Ok, I can change this. Envvar name "dfu_data_buf_size" is ok?
>>>
>>> Such long names are a paint to type. As we can't buffer anything else
>>> but data, we should be able to omit this, i. e. what about
>>>
>>> dfu_bufsiz
>>>
>>> ["bufsiz" as used for example as BUFSIZ in C89 stdio.h]
>>
>> Works for me.
>
> WFM, but I need to read the discussion around here. I just stopped playing dead
> beetle. Actually, I'm trying to find out why such a variable is needed at all.
> Can the buffer not be allocated dynamically (and thus dependant only on malloc
> area size)?
>
> Please ignore this if it's been answered in one of the emails I didn't read yet.
posted a v2 for this here:
http://patchwork.ozlabs.org/patch/250665/
which allocates the buffer in the malloc area, dependend on
the environemnt variable "dfu_bufsiz".
A reason why we should have at last a config option see here:
http://lists.denx.de/pipermail/u-boot/2013-June/155924.html
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2013-06-12 8:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 9:22 [U-Boot] dfu: make data buffer size configurable Heiko Schocher
2013-06-04 10:08 ` Pantelis Antoniou
2013-06-04 10:31 ` Heiko Schocher
2013-06-04 10:31 ` Pantelis Antoniou
2013-06-09 20:01 ` Marek Vasut
2013-06-10 4:28 ` Heiko Schocher
2013-06-10 5:48 ` Lukasz Majewski
2013-06-10 7:05 ` Wolfgang Denk
2013-06-10 15:51 ` Tom Rini
2013-06-12 8:36 ` Marek Vasut
2013-06-12 8:49 ` Heiko Schocher [this message]
2013-06-04 10:18 ` Lukasz Majewski
2013-06-04 20:04 ` Tom Rini
2013-06-05 4:53 ` Heiko Schocher
2013-06-05 12:43 ` Tom Rini
2013-06-05 14:04 ` Heiko Schocher
2013-06-06 15:55 ` Tom Rini
2013-06-07 6:05 ` Heiko Schocher
2013-06-07 7:28 ` Wolfgang Denk
2013-06-12 4:05 ` [U-Boot] [PATCH v2] " Heiko Schocher
2013-06-12 16:16 ` Tom Rini
2013-06-19 12:25 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B83612.9040009@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox