From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Date: Wed, 12 Jun 2013 21:26:03 +0200 Subject: [U-Boot] [PATCH v4 05/10] SPI: Add Dove SPI driver In-Reply-To: <51B8C4BA.2020708@gmail.com> References: <1369593423-19763-1-git-send-email-t-uboot@infra-silbe.de> <1369593423-19763-6-git-send-email-t-uboot@infra-silbe.de> <51B8C4BA.2020708@gmail.com> Message-ID: <51B8CB4B.8020704@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 06/12/2013 08:58 PM, Jagan Teki wrote: > On 03-06-2013 23:50, Jagan Teki wrote: >> Looks ok to me as per coding style after a quick look. >> On Mon, May 27, 2013 at 12:06 AM, Sascha Silbe >> wrote: >>> From: Sebastian Hesselbarth >>> >>> This adds an SPI driver for Marvell Dove SoCs. This driver is taken >>> from kirkwood_spi but removes mpp configuration as dove has dedicated >>> spi pins. >>> >>> As a future clean-up step, the code for orion5x, kirkwood and dove >>> could be merged, with MPP configuration being be handled as part of >>> cpu/board-specific setup. >>> >>> Signed-off-by: Sebastian Hesselbarth >>> Signed-off-by: Sascha Silbe >>> --- >>> v3->v4: renamed to dove, adjusted description, removed unused >>> variable, made checkpatch clean [...] > Any update on this. Is any of you even listening? Please do _not_ name it after Dove! It is compatible with _at least_ Kirkwood, Orion5x and MV78x00. Now is the chance to have a common name or you will end up with either non-sense naming or four copies of that very driver. Originally, it was named after the Linux group of SoCs compatible with Dove (orion-spi), IIRC Prafulla suggested mv-spi. Sebastian