From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chunhe Lan <b25806@freescale.com>
Date: Thu, 13 Jun 2013 15:02:46 +0800
Subject: [U-Boot] [PATCH v2] powerpc/85xx: Add P1023RDB board support
In-Reply-To: <1370973632.18413.28@snotra>
References: <1370973632.18413.28@snotra>
Message-ID: <51B96E96.1020105@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 06/12/2013 02:00 AM, Scott Wood wrote:
> On 06/09/2013 05:24:05 AM, Chunhe Lan wrote:
>> +    /* W**G* - Flash, localbus */
>> +    /* This will be changed to *I*G* after relocation to RAM. */
>> +    SET_TLB_ENTRY(1, CONFIG_SYS_FLASH_BASE, CONFIG_SYS_FLASH_BASE_PHYS,
>> +              MAS3_SX|MAS3_SW|MAS3_SR, MAS2_W|MAS2_G,
>> +              0, 2, BOOKE_PAGESZ_256M, 1),
>
> Do not set MAS3_SX on I/O regions.

           Here is need to use MAS3_SX, or u-boot does NOT work.

>> +/*
>> + * Memory map
>> + *
>> + * 0x0000_0000    0x1fff_ffff    DDR            500M Cacheable
>
> 500M?  Are you sure?

      Yes, system has the 500MB size of ddr.

Thanks,
-Chunhe

>> +#if defined(CONFIG_CMD_KGDB)
>> +#define CONFIG_KGDB_BAUDRATE    230400    /* speed to run kgdb 
>> serial port */
>> +#define CONFIG_KGDB_SER_INDEX    2    /* which serial port to use */
>> +#endif
>
> Get rid of this.
>
>> +#define CONFIG_BOOTDELAY 10    /* -1 disables auto-boot */
>
> The out-of-the-box environment is not going to work unmodified (I 
> don't even see a CONFIG_BOOTCOMMAND), so let's just default this to -1 
> now that it no longer has the affect of disabling the code at 
> compile-time.
>
> -Scott