public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Frédéric Leroy" <fredo@starox.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] LaCie kirkwood boards: allow disk > 2TB
Date: Thu, 13 Jun 2013 15:03:49 +0200	[thread overview]
Message-ID: <51B9C335.9000803@starox.org> (raw)
In-Reply-To: <20130613133352.4fa73a9e@lilith>

Le 13/06/2013 13:33, Albert ARIBAUD a ?crit :
> With gcc version 4.7.2 (Ubuntu/Linaro 4.7.2-2ubuntu1) this patch causes
> the following warning for all boards:
>
> cmd_ide.c:992:4: warning: right shift count >= width of type [enabled
> by default]
>
> Amicalement,

I will  convert every ide block number to 64 bit for disk and partitions.
I guess CONFIG_LBA48 is also broken in common/cmd_ide.c :

ulong ide_write(int device, ulong blknr, lbaint_t blkcnt, const void
*buffer)
{
    ulong n = 0;
    unsigned char c;

#ifdef CONFIG_LBA48
    unsigned char lba48 = 0;

    if (blknr & 0x0000fffff0000000ULL) {                          <= issue
        /* more than 28 bits used, use 48bit mode */
        lba48 = 1;
    }
#endif

I hope this won't break anything, it is a big change impacting everybody :(

Sinc?rement,

-- 
Fr?d?ric

  reply	other threads:[~2013-06-13 13:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-10 13:30 [U-Boot] [PATCH] LaCie kirkwood boards: allow disk > 2TB Frederic Leroy
2013-06-10 13:44 ` Simon Guinot
2013-06-10 14:20   ` Frédéric Leroy
2013-06-10 14:29     ` Simon Guinot
2013-06-10 14:48       ` Albert ARIBAUD
2013-06-13 11:33 ` Albert ARIBAUD
2013-06-13 13:03   ` Frédéric Leroy [this message]
2013-06-13 13:21     ` Albert ARIBAUD
2013-06-13 13:36       ` Frédéric Leroy
2013-06-13 20:32     ` Sascha Silbe
2013-06-14 11:07       ` [U-Boot] [PATCH] Fix block device accesses beyond 2TiB Sascha Silbe
2013-06-17 20:26         ` Marek Vasut
2013-06-22 10:07           ` Albert ARIBAUD
     [not found]             ` <51C598A6.8040406@starox.org>
2013-06-22 15:31               ` Albert ARIBAUD
2013-06-24  9:46                 ` Frédéric Leroy
2013-06-24 21:13                   ` Sascha Silbe
2013-06-24 21:26                     ` [U-Boot] [PATCH] Fix ext2/ext4 filesystem " Frederic Leroy
2013-06-24 22:26                       ` Sascha Silbe
2013-06-25  6:10                         ` Frederic Leroy
2013-06-25 20:42                           ` Sascha Silbe
2013-06-26 16:11                             ` [U-Boot] [PATCH v2] " Frédéric Leroy
2013-07-11 10:41                               ` Albert ARIBAUD
2013-07-16 14:37                               ` [U-Boot] [U-Boot, " Tom Rini
2013-06-26 20:25         ` [U-Boot] Fix block device " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B9C335.9000803@starox.org \
    --to=fredo@starox.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox