From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?RnLDqWTDqXJpYyBMZXJveQ==?= <fredo@starox.org>
Date: Thu, 13 Jun 2013 15:03:49 +0200
Subject: [U-Boot] [PATCH] LaCie kirkwood boards: allow disk > 2TB
In-Reply-To: <20130613133352.4fa73a9e@lilith>
References: <1370871053-14524-1-git-send-email-fredo@starox.org>
	<20130613133352.4fa73a9e@lilith>
Message-ID: <51B9C335.9000803@starox.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Le 13/06/2013 13:33, Albert ARIBAUD a ?crit :
> With gcc version 4.7.2 (Ubuntu/Linaro 4.7.2-2ubuntu1) this patch causes
> the following warning for all boards:
>
> cmd_ide.c:992:4: warning: right shift count >= width of type [enabled
> by default]
>
> Amicalement,

I will  convert every ide block number to 64 bit for disk and partitions.
I guess CONFIG_LBA48 is also broken in common/cmd_ide.c :

ulong ide_write(int device, ulong blknr, lbaint_t blkcnt, const void
*buffer)
{
    ulong n = 0;
    unsigned char c;

#ifdef CONFIG_LBA48
    unsigned char lba48 = 0;

    if (blknr & 0x0000fffff0000000ULL) {                          <= issue
        /* more than 28 bits used, use 48bit mode */
        lba48 = 1;
    }
#endif

I hope this won't break anything, it is a big change impacting everybody :(

Sinc?rement,

-- 
Fr?d?ric