From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Date: Thu, 13 Jun 2013 19:38:42 +0530 Subject: [U-Boot] [PATCH 2/2] spi: tegra20_sflash: Remove redundant code to set bus and cs of struct spi_slave In-Reply-To: <201306131248.39579.marex@denx.de> References: <1371111467.24768.3.camel@phoenix> <1371111702.24768.7.camel@phoenix> <201306131248.39579.marex@denx.de> Message-ID: <51B9D26A.9090109@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 13-06-2013 16:18, Marek Vasut wrote: > Dear Axel Lin, > >> It's done in spi_alloc_slave(), thus remove the redundant code. >> >> Signed-off-by: Axel Lin >> --- >> drivers/spi/tegra20_sflash.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/spi/tegra20_sflash.c b/drivers/spi/tegra20_sflash.c >> index 9322ce7..7c3a3fc 100644 >> --- a/drivers/spi/tegra20_sflash.c >> +++ b/drivers/spi/tegra20_sflash.c >> @@ -132,8 +132,6 @@ struct spi_slave *tegra20_spi_setup_slave(unsigned int >> bus, unsigned int cs, printf("SPI error: malloc of SPI structure >> failed\n"); >> return NULL; >> } >> - spi->slave.bus = bus; >> - spi->slave.cs = cs; >> spi->ctrl = &spi_ctrls[bus]; >> if (!spi->ctrl) { >> printf("SPI error: could not find controller for bus %d\n", > > Acked-by: Marek Vasut > > Best regards, > Marek Vasut > Reviewed-by: Jagannadha Sutradharudu Teki -- Thanks, Jagan.