From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 14 Jun 2013 11:07:08 -0400 Subject: [U-Boot] [PATCH] fdt: Ensure that libfdt_env.h comes from U-Boot In-Reply-To: References: <1363019427-31520-1-git-send-email-sjg@chromium.org> <20130417153554.GA14952@bill-the-cat> Message-ID: <51BB319C.8040108@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/14/2013 10:56 AM, Joe Hershberger wrote: > Hi Simon, > > On Wed, Apr 17, 2013 at 10:35 AM, Tom Rini wrote: >> On Mon, Mar 11, 2013 at 09:30:27AM -0700, Simon Glass wrote: >> >>> When building host utilities, we include libfdt.h from the >>> host, not from U-Boot. This in turn brings in libfdt_env.h from >>> the host, which can mess up the types and cause a build >>> failure, depending on the host environment. To fix this, force >>> inclusion of U-Boot's libfdt_env.h so that the types are >>> correct. >>> >>> Another way to fix this is to use -nostdinc and -idirafter to >>> ensure that system includes are included after U-Boot ones. >>> Unfortunately this means that U-Boot's errno.h gets included >>> instead of the system one. This in turn requires a hack to >>> errno.h to redirect things, so all in all the solution in this >>> patch is probably cleaner. >>> >>> Signed-off-by: Simon Glass >> >> Applied to u-boot/master, thanks! >> >> -- Tom > > For me this patch causes a regression that looks like this: > > Configuring for sandbox board... aisimage.c: In function > ?aisimage_generate?: aisimage.c:314: warning: implicit declaration > of function ?getline? imximage.c: In function ?parse_cfg_file?: > imximage.c:424: warning: implicit declaration of function > ?getline? kwbimage.c: In function ?kwdimage_set_ext_header?: > kwbimage.c:236: warning: implicit declaration of function > ?getline? pblimage.c: In function ?pbl_parser?: pblimage.c:119: > warning: implicit declaration of function ?getline? ublimage.c: In > function ?parse_cfg_file?: ublimage.c:179: warning: implicit > declaration of function ?getline? > > Did you not see this? I see it on ARM, PPC, and sandbox. Nope. What toolchains? - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRuzGcAAoJENk4IS6UOR1W2KEP/Roaf4ewQxnpag59QdHHy7GJ FaMHOA36GbjLt8ay4KaEfFazxpmJiVPWApEt5RkbKICa8sYot6X+nmcOhLMau46t /mSx5ig6NMQeCvVmFvppRmBdJvew1dfxGiIAXd8GEAQQgDQsJ18KS0qOOyr9UlUI o+z6unVXybQQgsijiQaph2uhIkV2Fo5wUY2JrNzbHDepjHgKkfS+6CeIRxJE7+yr sCyn5hAAWDBIUR3Xlqw2pfrWPCNJNORSQhWtfMNVQbf1PFUYEv4U008QldsaR1qF AcXZv7tzXahJYYqQTKuEGIdO9Ed9Ij3eJ+oPg5guZ5+6PYoX8ZLAyOKEtp/hdFs6 bHXdj5URUzv1bW81p4Hsuk+O+h1izIgqeUqfzTQfnZucgCPl87HVsevdA2N22deC 2PuM8vvEdl0UgJmwd9fFyrUYXzE+xzOLf3XRXVwOWtKrQUl8WE6FMmkGfAWLQNNx LbXwmyQKXOPM1YAM+P7mxEk4L7gpeRF/r+uARBJ36Oi1RtY4zM16FYT25cOoppuL aFCssOuxL02WiX4q9EWZ8sGtJ9H6c5Dz/oFMwWmse9i+QNMnLGpoS4m6imnDJw26 yju4fIztjajAJN+dFV5J9CJHp2ddon3sa+6Sdn7aEBrCUgjU0Zi9ne+Ge+UghoRG 3fHhQNqmvtq0OgrCmLPY =+4Fc -----END PGP SIGNATURE-----