* [U-Boot] [PATCH] image: Use ENOENT instead of ENOMEDIUM for better compatibility
@ 2013-06-16 14:46 Simon Glass
2013-06-16 17:17 ` [U-Boot] " Jeroen Hofstee
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Simon Glass @ 2013-06-16 14:46 UTC (permalink / raw)
To: u-boot
This error may not be defined on some platforms such as MacOS so host
compilation will fail. Use one of the more common errors instead.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
common/image-fit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/image-fit.c b/common/image-fit.c
index 7bf82d3..f40f160 100644
--- a/common/image-fit.c
+++ b/common/image-fit.c
@@ -1557,7 +1557,7 @@ int fit_image_load(bootm_headers_t *images, const char *prop_name, ulong addr,
if (fit_image_get_data(fit, noffset, &buf, &size)) {
printf("Could not find %s subimage data!\n", prop_name);
bootstage_error(bootstage_id + BOOTSTAGE_SUB_GET_DATA);
- return -ENOMEDIUM;
+ return -ENOENT;
}
len = (ulong)size;
--
1.8.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] image: Use ENOENT instead of ENOMEDIUM for better compatibility
2013-06-16 14:46 [U-Boot] [PATCH] image: Use ENOENT instead of ENOMEDIUM for better compatibility Simon Glass
@ 2013-06-16 17:17 ` Jeroen Hofstee
2013-06-17 6:34 ` [U-Boot] [PATCH] " Andreas Bießmann
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Jeroen Hofstee @ 2013-06-16 17:17 UTC (permalink / raw)
To: u-boot
Hello Simon,
On 06/16/2013 04:46 PM, Simon Glass wrote:
> This error may not be defined on some platforms such as MacOS so host
> compilation will fail. Use one of the more common errors instead.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
>
> ---
> common/image-fit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/image-fit.c b/common/image-fit.c
> index 7bf82d3..f40f160 100644
> --- a/common/image-fit.c
> +++ b/common/image-fit.c
> @@ -1557,7 +1557,7 @@ int fit_image_load(bootm_headers_t *images, const char *prop_name, ulong addr,
> if (fit_image_get_data(fit, noffset, &buf, &size)) {
> printf("Could not find %s subimage data!\n", prop_name);
> bootstage_error(bootstage_id + BOOTSTAGE_SUB_GET_DATA);
> - return -ENOMEDIUM;
> + return -ENOENT;
> }
> len = (ulong)size;
>
This fixes building for FreeBSD as well, thanks.
Regards,
Jeroen
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] image: Use ENOENT instead of ENOMEDIUM for better compatibility
2013-06-16 14:46 [U-Boot] [PATCH] image: Use ENOENT instead of ENOMEDIUM for better compatibility Simon Glass
2013-06-16 17:17 ` [U-Boot] " Jeroen Hofstee
@ 2013-06-17 6:34 ` Andreas Bießmann
2013-06-17 7:04 ` Lubomir Popov
2013-06-17 13:57 ` Tom Rini
3 siblings, 0 replies; 5+ messages in thread
From: Andreas Bießmann @ 2013-06-17 6:34 UTC (permalink / raw)
To: u-boot
On 16.06.13 16:46, Simon Glass wrote:
> This error may not be defined on some platforms such as MacOS so host
> compilation will fail. Use one of the more common errors instead.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Tested-by: Andreas Bie?mann <andreas.devel@googlemail.com>
on OS X 10.7.5
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] image: Use ENOENT instead of ENOMEDIUM for better compatibility
2013-06-16 14:46 [U-Boot] [PATCH] image: Use ENOENT instead of ENOMEDIUM for better compatibility Simon Glass
2013-06-16 17:17 ` [U-Boot] " Jeroen Hofstee
2013-06-17 6:34 ` [U-Boot] [PATCH] " Andreas Bießmann
@ 2013-06-17 7:04 ` Lubomir Popov
2013-06-17 13:57 ` Tom Rini
3 siblings, 0 replies; 5+ messages in thread
From: Lubomir Popov @ 2013-06-17 7:04 UTC (permalink / raw)
To: u-boot
On 16.06.2013 17:46, Simon Glass wrote:
> This error may not be defined on some platforms such as MacOS so host
> compilation will fail. Use one of the more common errors instead.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Tested-by: Lubomir Popov <lpopov@mm-sol.com>
on MacOS X 10.8.3 with the following tools used for building U-Boot:
arm-none-eabi-gcc (GCC) 4.7.2
GNU ld (GNU Binutils) 2.23.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] image: Use ENOENT instead of ENOMEDIUM for better compatibility
2013-06-16 14:46 [U-Boot] [PATCH] image: Use ENOENT instead of ENOMEDIUM for better compatibility Simon Glass
` (2 preceding siblings ...)
2013-06-17 7:04 ` Lubomir Popov
@ 2013-06-17 13:57 ` Tom Rini
3 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2013-06-17 13:57 UTC (permalink / raw)
To: u-boot
On Sun, Jun 16, 2013 at 07:46:49AM -0700, Simon Glass wrote:
> This error may not be defined on some platforms such as MacOS so host
> compilation will fail. Use one of the more common errors instead.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130617/f7c6d7ce/attachment.pgp>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-17 13:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-16 14:46 [U-Boot] [PATCH] image: Use ENOENT instead of ENOMEDIUM for better compatibility Simon Glass
2013-06-16 17:17 ` [U-Boot] " Jeroen Hofstee
2013-06-17 6:34 ` [U-Boot] [PATCH] " Andreas Bießmann
2013-06-17 7:04 ` Lubomir Popov
2013-06-17 13:57 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox