public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cm_t35: Fix cm_t35 for weak splash_screen_prepare
Date: Mon, 17 Jun 2013 08:48:58 +0300	[thread overview]
Message-ID: <51BEA34A.3080707@compulab.co.il> (raw)
In-Reply-To: <1371238293-5879-1-git-send-email-robert.winkler@boundarydevices.com>

Hi Robert,

We lack a commit message here...

On 06/14/13 22:31, Robert Winkler wrote:
> Signed-off-by: Robert Winkler <robert.winkler@boundarydevices.com>
> ---

Also, I would write here (not a part of commit message)
that this patch should be applied only in case the patch:
"video: lcd: Make splash_screen_prepare weak, remove config macro
is applied.

May be it is even better to make this patch the 3rd in the series
changing the splash prepare stuff?

>  board/compulab/cm_t35/cm_t35.c | 2 +-
>  include/configs/cm_t35.h       | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/board/compulab/cm_t35/cm_t35.c b/board/compulab/cm_t35/cm_t35.c
> index b0b80e5..95098af 100644
> --- a/board/compulab/cm_t35/cm_t35.c
> +++ b/board/compulab/cm_t35/cm_t35.c
> @@ -120,7 +120,7 @@ static inline int splash_load_from_nand(void)
>  }
>  #endif /* CONFIG_CMD_NAND */
>  
> -int board_splash_screen_prepare(void)
> +int splash_screen_prepare(void)
>  {
>  	char *env_splashimage_value;
>  	u32 bmp_load_addr;
> diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h
> index c6e357a..b258da9 100644
> --- a/include/configs/cm_t35.h
> +++ b/include/configs/cm_t35.h
> @@ -339,6 +339,5 @@
>  #define CONFIG_SPLASH_SCREEN
>  #define CONFIG_CMD_BMP
>  #define CONFIG_BMP_16BPP
> -#define CONFIG_SPLASH_SCREEN_PREPARE
>  
>  #endif /* __CONFIG_H */
> 

-- 
Regards,
Igor.

      reply	other threads:[~2013-06-17  5:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14 19:31 [U-Boot] [PATCH] cm_t35: Fix cm_t35 for weak splash_screen_prepare Robert Winkler
2013-06-17  5:48 ` Igor Grinberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51BEA34A.3080707@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox