From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andreas_Bie=DFmann?= Date: Mon, 17 Jun 2013 08:38:26 +0200 Subject: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path In-Reply-To: References: Message-ID: <51BEAEE2.8050700@googlemail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Joel A Fernandes, On 16.06.13 17:44, Joel A Fernandes wrote: > On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote: > >> From: Jagannadha Sutradharudu Teki >>> >> >> checkpatch.pl requires perl v5.10.0 to run but it >> doesn't require to place in /usr/bin/perl >> Use env to ensure that the interpreter used is the >> first one on environment's $PATH on system with >> several versions of perl installed. >> >> Signed-off-by: Jagannadha Sutradharudu Teki >>> >> --- >> tools/checkpatch.pl | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl >> index 896e2bc..8dc5b9c 100755 >> --- a/tools/checkpatch.pl >> +++ b/tools/checkpatch.pl >> @@ -1,10 +1,11 @@ >> -#!/usr/bin/perl -w >> +#!/usr/bin/env perl > > > Would it not work to pass in the -w here? this is not portable! BSD variants of env will only take a single parameter. Best regards Andreas Bie?mann