[U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path

[U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path

[Jagannadha Sutradharudu Teki]

From: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>

checkpatch.pl requires perl v5.10.0 to run but it
doesn't require to place in /usr/bin/perl
Use env to ensure that the interpreter used is the
first one on environment's $PATH on system with
several versions of perl installed.

Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
---
 tools/checkpatch.pl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
index 896e2bc..8dc5b9c 100755
--- a/tools/checkpatch.pl
+++ b/tools/checkpatch.pl
@@ -1,10 +1,11 @@
-#!/usr/bin/perl -w
+#!/usr/bin/env perl
 # (c) 2001, Dave Jones. (the file handling bit)
 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
 # Licensed under the terms of the GNU GPL License version 2
 
+use warnings;
 use strict;
 
 my $P = $0;
-- 
1.8.3

[U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path

[Sumit Gemini]

Hi ALL,

      Could any buddy tell me how can I define bootcount value after each
reset cycle, right now i am using SRAM but when boot loader pass the
control to kernel, it reset Sram memory so i lost my bootcount value.
please suggest me another idea for storing bootcount value...

My another query is I want to increase my bootcount value when system is
being reset by watchdog only..

Any pointer from you guys would be help me.


Thanks
~Sumit Gemini


On Sun, Jun 16, 2013 at 12:46 PM, Jagannadha Sutradharudu Teki <
jagannadha.sutradharudu-teki@xilinx.com> wrote:

> From: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
>
> checkpatch.pl requires perl v5.10.0 to run but it
> doesn't require to place in /usr/bin/perl
> Use env to ensure that the interpreter used is the
> first one on environment's $PATH on system with
> several versions of perl installed.
>
> Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
> ---
>  tools/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
> index 896e2bc..8dc5b9c 100755
> --- a/tools/checkpatch.pl
> +++ b/tools/checkpatch.pl
> @@ -1,10 +1,11 @@
> -#!/usr/bin/perl -w
> +#!/usr/bin/env perl
>  # (c) 2001, Dave Jones. (the file handling bit)
>  # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
>  # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test
> suite)
>  # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
>  # Licensed under the terms of the GNU GPL License version 2
>
> +use warnings;
>  use strict;
>
>  my $P = $0;
> --
> 1.8.3
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

[U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path

[Michael Trimarchi]

Hi

Il giorno 16/giu/2013 11:55, "Sumit Gemini" <sumit.gemini0@gmail.com> ha
scritto:
>
> Hi ALL,
>
>       Could any buddy tell me how can I define bootcount value after each
> reset cycle, right now i am using SRAM but when boot loader pass the
> control to kernel, it reset Sram memory so i lost my bootcount value.

Is this your comment on the patch?

I suggest to create a new thread and at describe your architecture.

Michael

> please suggest me another idea for storing bootcount value...
>
> My another query is I want to increase my bootcount value when system is
> being reset by watchdog only..
>
> Any pointer from you guys would be help me.
>
>
> Thanks
> ~Sumit Gemini
>
>
> On Sun, Jun 16, 2013 at 12:46 PM, Jagannadha Sutradharudu Teki <
> jagannadha.sutradharudu-teki at xilinx.com> wrote:
>
> > From: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
> >
> > checkpatch.pl requires perl v5.10.0 to run but it
> > doesn't require to place in /usr/bin/perl
> > Use env to ensure that the interpreter used is the
> > first one on environment's $PATH on system with
> > several versions of perl installed.
> >
> > Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
> > ---
> >  tools/checkpatch.pl | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
> > index 896e2bc..8dc5b9c 100755
> > --- a/tools/checkpatch.pl
> > +++ b/tools/checkpatch.pl
> > @@ -1,10 +1,11 @@
> > -#!/usr/bin/perl -w
> > +#!/usr/bin/env perl
> >  # (c) 2001, Dave Jones. (the file handling bit)
> >  # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
> >  # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test
> > suite)
> >  # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
> >  # Licensed under the terms of the GNU GPL License version 2
> >
> > +use warnings;
> >  use strict;
> >
> >  my $P = $0;
> > --
> > 1.8.3
> >
> >
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
> >
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

[U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path

[Tom Rini]

On Sun, Jun 16, 2013 at 12:46:37PM +0530, Jagannadha Sutradharudu Teki wrote:

> From: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
> 
> checkpatch.pl requires perl v5.10.0 to run but it
> doesn't require to place in /usr/bin/perl
> Use env to ensure that the interpreter used is the
> first one on environment's $PATH on system with
> several versions of perl installed.
> 
> Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
> ---
>  tools/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
> index 896e2bc..8dc5b9c 100755
> --- a/tools/checkpatch.pl
> +++ b/tools/checkpatch.pl
> @@ -1,10 +1,11 @@
> -#!/usr/bin/perl -w
> +#!/usr/bin/env perl
>  # (c) 2001, Dave Jones. (the file handling bit)
>  # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
>  # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
>  # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
>  # Licensed under the terms of the GNU GPL License version 2
>  
> +use warnings;
>  use strict;
>  
>  my $P = $0;

Lets get this to come in via the kernel please, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130616/38b704a3/attachment.pgp>

[U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path

[Joel A Fernandes]

On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote:

> From: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com<javascript:;>
> >
>
> checkpatch.pl requires perl v5.10.0 to run but it
> doesn't require to place in /usr/bin/perl
> Use env to ensure that the interpreter used is the
> first one on environment's $PATH on system with
> several versions of perl installed.
>
> Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com<javascript:;>
> >
> ---
>  tools/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
> index 896e2bc..8dc5b9c 100755
> --- a/tools/checkpatch.pl
> +++ b/tools/checkpatch.pl
> @@ -1,10 +1,11 @@
> -#!/usr/bin/perl -w
> +#!/usr/bin/env perl


Would it not work to pass in the -w here?

Joel


>  # (c) 2001, Dave Jones. (the file handling bit)
>  # (c) 2005, Joel Schopp <jschopp@austin.ibm.com <javascript:;>> (the
> ugly bit)
>  # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com <javascript:;>> (new
> conditions, test suite)
>  # (c) 2008-2010 Andy Whitcroft <apw@canonical.com <javascript:;>>
>  # Licensed under the terms of the GNU GPL License version 2
>
> +use warnings;
>  use strict;
>
>  my $P = $0;
> --
> 1.8.3
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de <javascript:;>
> http://lists.denx.de/mailman/listinfo/u-boot
>

[U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path

[Jagannadha Sutradharudu Teki]

From: Joel A Fernandes [mailto:agnel.joel at gmail.com]
Sent: 16 June 2013 21:15
To: Jagannadha Sutradharudu Teki
Cc: u-boot at lists.denx.de; Tom Rini
Subject: Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path



On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote:
From: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>

checkpatch.pl<http://checkpatch.pl> requires perl v5.10.0 to run but it
doesn't require to place in /usr/bin/perl
Use env to ensure that the interpreter used is the
first one on environment's $PATH on system with
several versions of perl installed.

Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
---
 tools/checkpatch.pl<http://checkpatch.pl> | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/checkpatch.pl<http://checkpatch.pl> b/tools/checkpatch.pl<http://checkpatch.pl>
index 896e2bc..8dc5b9c 100755
--- a/tools/checkpatch.pl<http://checkpatch.pl>
+++ b/tools/checkpatch.pl<http://checkpatch.pl>
@@ -1,10 +1,11 @@
-#!/usr/bin/perl -w
+#!/usr/bin/env perl

Would it not work to pass in the -w here?

Yes it will not work just to pass -w
It's taking -w as a file.

Thanks,
Jagan.

Joel

 # (c) 2001, Dave Jones. (the file handling bit)
 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
 # Licensed under the terms of the GNU GPL License version 2

+use warnings;
 use strict;

 my $P = $0;
--
1.8.3


_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

[U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path

[Andreas Bießmann]

Dear Joel A Fernandes,

On 16.06.13 17:44, Joel A Fernandes wrote:
> On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote:
> 
>> From: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com<javascript:;>
>>>
>>
>> checkpatch.pl requires perl v5.10.0 to run but it
>> doesn't require to place in /usr/bin/perl
>> Use env to ensure that the interpreter used is the
>> first one on environment's $PATH on system with
>> several versions of perl installed.
>>
>> Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com<javascript:;>
>>>
>> ---
>>  tools/checkpatch.pl | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
>> index 896e2bc..8dc5b9c 100755
>> --- a/tools/checkpatch.pl
>> +++ b/tools/checkpatch.pl
>> @@ -1,10 +1,11 @@
>> -#!/usr/bin/perl -w
>> +#!/usr/bin/env perl
> 
> 
> Would it not work to pass in the -w here?

this is not portable! BSD variants of env will only take a single parameter.

Best regards

Andreas Bie?mann

[U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path

[Joel A Fernandes]

On Mon, Jun 17, 2013 at 1:38 AM, Andreas Bie?mann
<andreas.devel@googlemail.com> wrote:
> Dear Joel A Fernandes,
>
> On 16.06.13 17:44, Joel A Fernandes wrote:
>> On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote:
>>
>>> From: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com<javascript:;>
>>>>
>>>
>>> checkpatch.pl requires perl v5.10.0 to run but it
>>> doesn't require to place in /usr/bin/perl
>>> Use env to ensure that the interpreter used is the
>>> first one on environment's $PATH on system with
>>> several versions of perl installed.
>>>
>>> Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com<javascript:;>
>>>>
>>> ---
>>>  tools/checkpatch.pl | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
>>> index 896e2bc..8dc5b9c 100755
>>> --- a/tools/checkpatch.pl
>>> +++ b/tools/checkpatch.pl
>>> @@ -1,10 +1,11 @@
>>> -#!/usr/bin/perl -w
>>> +#!/usr/bin/env perl
>>
>>
>> Would it not work to pass in the -w here?
>
> this is not portable! BSD variants of env will only take a single parameter.
>

Sure yes I noticed that, this is an acceptable approach though I've
seen some cases people solve the problem using exec.

Thanks,
Joel