From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 17 Jun 2013 12:40:32 +0200 Subject: [U-Boot] [PATCH] spi: Use DIV_ROUND_UP at appropriate places In-Reply-To: References: <1371196742.20321.1.camel@phoenix> Message-ID: <51BEE7A0.5050602@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 14/06/2013 15:18, Jagan Teki wrote: >> This does not scale. >> What if a (trivial) patch touches 10 drivers? > Yes, you are correct if the changes is common to across the all drivers or > If the changes which are more in 10 spi drivers out of 20 or > 10 for > your example - use "spi: " > and I think it's good to use above syntax as you changesd two drivers. > > I am just showing the possibilities of using the coding guidelines, > nothing more. There is another issue: patman recognizes each : and checks for an alias to find the e-mail to send patches, and stops to go on if it is not found. In this example, you can use patman if there is an entry for spi: (and this is you as SPI custodian) and also for mxc_spi:, and usually there is no maintainer for each driver. I agree that using a long chain does not scale, and I think the hidden rule to use works well in most cases, Axel did in this patchset. Regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================