From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 17 Jun 2013 12:49:49 +0200 Subject: [U-Boot] [PATCH] ARM: mxs: Make the console buffer smaller In-Reply-To: <1371332488-13026-1-git-send-email-marex@denx.de> References: <1371332488-13026-1-git-send-email-marex@denx.de> Message-ID: <51BEE9CD.8090002@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, On 15/06/2013 23:41, Marek Vasut wrote: > Using 1024 bytes for console buffer is unnecessarily too much, > lower the amount for all MXS boards to 256. > > Signed-off-by: Marek Vasut > Cc: Fabio Estevam > Cc: Lauri Hintsala > Cc: Otavio Salvador > Cc: Stefano Babic > --- > include/configs/mxs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Note: This depends on http://patchwork.ozlabs.org/patch/251631/ > > diff --git a/include/configs/mxs.h b/include/configs/mxs.h > index a684166..161d89d 100644 > --- a/include/configs/mxs.h > +++ b/include/configs/mxs.h > @@ -92,7 +92,7 @@ > #ifndef CONFIG_SYS_PROMPT > #define CONFIG_SYS_PROMPT "=> " > #endif > -#define CONFIG_SYS_CBSIZE 1024 /* Console I/O buffer size */ > +#define CONFIG_SYS_CBSIZE 256 /* Console I/O buffer size */ > #define CONFIG_SYS_PBSIZE \ > (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16) > /* Print buffer size */ > I am missing something: which is the real advantage to reduce the console buffer ? I do not think that the saved memory is worth, and on the other side more elaborated scripts (usings nested if-then-else) are quite long nowadays. Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================