From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/8] dts/Makefile: simplify dtc invocation
Date: Wed, 19 Jun 2013 14:43:09 -0600 [thread overview]
Message-ID: <51C217DD.2090209@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ1tNR_LcV7Qpp--R4Mxer_N2+SjWr+ZfQ+5YJBK=ScoNg@mail.gmail.com>
On 06/19/2013 02:37 PM, Simon Glass wrote:
> Hi Stephen,
>
> On Mon, Jun 10, 2013 at 4:16 PM, Stephen Warren <swarren@wwwdotorg.org
> <mailto:swarren@wwwdotorg.org>> wrote:
...
> Related, split the invocation of cpp and dtc into separate commands
> rather than a pipeline, so that if either fail, it is detected. This has
> the nice benefit of saving off the result of the pre-processing step,
> allowing it to be easily inspected.
...
> diff --git a/.gitignore b/.gitignore
...
> $(DT_BIN): $(TOPDIR)/board/$(VENDOR)/dts/$(DEVICE_TREE).dts
...
> + $(CPP) -P $(DTS_CPPFLAGS) $< -o $(DT_BIN).dtstmp
> + $(DTC) -R 4 -p 0x1000 -O dtb -o ${DT_BIN} $(DT_BIN).dtstmp
>
>
> When you get an error here, will dtc report a bogus filename? Or will
> the CPP line information deal with that> - iwc please add a comment to
> the commit message.
Added this to commit description:
Assuming a new enough dtc (which an earlier patch enforces), dtc will
parse #line directives in its input file, and generate correct file and
line numbers in error messages, even though cpp is unconditionally
applied to its input file.
(note the patch that refers to will be new in v2 of the series).
next prev parent reply other threads:[~2013-06-19 20:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 23:16 [U-Boot] [PATCH 0/8] rely on latest dtc, simplify Stephen Warren
2013-06-10 23:16 ` [U-Boot] [PATCH 1/8] xilinx: move microblaze-generic .dts to standard location Stephen Warren
2013-06-19 20:36 ` Simon Glass
2013-06-20 5:24 ` Michal Simek
2013-06-10 23:16 ` [U-Boot] [PATCH 2/8] dts/Makefile: simplify dtc invocation Stephen Warren
2013-06-19 20:37 ` Simon Glass
2013-06-19 20:43 ` Stephen Warren [this message]
2013-06-10 23:16 ` [U-Boot] [PATCH 3/8] dts/Makefile: unify cpp/dtc include paths Stephen Warren
2013-06-19 20:51 ` Simon Glass
2013-06-19 20:56 ` Stephen Warren
2013-06-19 21:09 ` Simon Glass
2013-06-10 23:17 ` [U-Boot] [PATCH 4/8] dt: don't use ARCH_CPU_DTS Stephen Warren
2013-06-19 20:52 ` Simon Glass
2013-06-10 23:17 ` [U-Boot] [PATCH 5/8] dts/Makefile: don't define ARCH_CPU_DTS, BOARD_DTS Stephen Warren
2013-06-19 20:54 ` Simon Glass
2013-06-10 23:17 ` [U-Boot] [PATCH 6/8] config: don't define CONFIG_ARCH_DEVICE_TREE Stephen Warren
2013-06-11 6:52 ` Jagan Teki
2013-06-11 16:03 ` Stephen Warren
2013-06-19 20:56 ` Simon Glass
2013-06-10 23:17 ` [U-Boot] [PATCH 7/8] dts/Makefile: don't use cpp -P Stephen Warren
2013-06-19 20:58 ` Simon Glass
2013-06-10 23:17 ` [U-Boot] [PATCH 8/8] dts/Makefile: pass -undef -D__DTS__ to cpp Stephen Warren
2013-06-19 21:01 ` Simon Glass
2013-06-11 16:19 ` [U-Boot] [PATCH 0/8] rely on latest dtc, simplify Tom Rini
2013-06-11 16:36 ` Stephen Warren
2013-06-11 22:09 ` Tom Rini
2013-06-19 12:46 ` Tom Rini
2013-06-19 15:38 ` Stephen Warren
2013-06-19 15:44 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C217DD.2090209@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox