From: Nikita Kiryanov <nikita@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] gpio: omap_gpio: Remove check_gpio() function
Date: Thu, 20 Jun 2013 08:19:33 +0300 [thread overview]
Message-ID: <51C290E5.50703@compulab.co.il> (raw)
In-Reply-To: <1371690189.3940.1.camel@phoenix>
Hi Axel,
On 06/20/2013 04:03 AM, Axel Lin wrote:
> check_gpio() and gpio_is_valid() are both used to check if a gpio is valid or
> not. It looks pointless to have both function because we can just call
> gpio_is_valid() instead of check_gpio(). Thus remove check_gpio() function.
I don't see the benefit in this patch.
The functions clearly exist for different reasons: gpio_is_valid() is
part of the gpio api, while check_gpio() exists to attach an error
message to a failed validity check without causing code duplication all
over omap_gpio.c.
Essentially what you are doing is removing a helpful error message.
--
Regards,
Nikita.
next prev parent reply other threads:[~2013-06-20 5:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 1:03 [U-Boot] [PATCH] gpio: omap_gpio: Remove check_gpio() function Axel Lin
2013-06-20 5:19 ` Nikita Kiryanov [this message]
2013-06-20 7:20 ` Axel Lin
2013-06-20 7:44 ` Nikita Kiryanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C290E5.50703@compulab.co.il \
--to=nikita@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox