From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 1/3] ARM: Tegra: FDT: Add USB EHCI function for T30/T114
Date: Thu, 20 Jun 2013 09:56:38 -0600 [thread overview]
Message-ID: <51C32636.3040903@wwwdotorg.org> (raw)
In-Reply-To: <20130620111743.GA29274@manwe>
On 06/20/2013 05:17 AM, Thierry Reding wrote:
> On Thu, Jun 20, 2013 at 04:13:38PM +0800, Jim Lin wrote:
>> Add DT node for USB EHCI function. Add support for T30-Cardhu,
>> T30-Beaver, T114-Dalmore boards.
>>
>> Signed-off-by: Jim Lin <jilin@nvidia.com> --- Changes in v2: -
>> Remove PLL parameters from dt file Changes in v3: - Change VBus
>> GPIO from H.05 to DD.04 for Beaver board. Changes in v4: - Change
>> Beaver VBus GPIO to H.05 and value to 0 for polarity to be High.
>> I don't have Beaver board. So this needs somebody to help test.
>> Thanks.
>
> Why did you change it back to H.05 again? I already tested
> successfully that DD.04 is the right one.
Yes, such a change is clearly wrong. Jim, you have access to the
schematics for all these boards. Please use them.
The correct values are:
Beaver:
USB1 VBUS: PEX_L1_CLKREQ / PDD6 / 238
USB3 VBUS: PEX_L1_PRSNT / PDD4 / 236
Incorrect: GMI_AD13 / PH5 / 61
(This is a signal that pulls up all of USB1 VBUS, USB3 VBUS, and
GMI_AD15, which as far as I can tell is entirely unrelated to USB in
any way)
Cardhu A04:
USB1 VBUS: PEX_L1_CLKREQ / PDD6 / 238
USB3 VBUS: PEX_L1_PRSNT / PDD4 / 236
Incorrect: PEX_L0_RST / PDD1 / 233
(This is a signal that pulls up a whole slew of signals, many of which
are entirely unrelated to USB in any way)
next prev parent reply other threads:[~2013-06-20 15:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 8:13 [U-Boot] [PATCH v4 1/3] ARM: Tegra: FDT: Add USB EHCI function for T30/T114 Jim Lin
2013-06-20 8:13 ` [U-Boot] [PATCH v4 2/3] ARM: Tegra: USB: EHCI: Add support for Tegra30/Tegra114 Jim Lin
2013-06-20 16:19 ` Stephen Warren
2013-06-20 17:20 ` Jim Lin
2013-06-20 17:40 ` Stephen Warren
2013-06-20 8:13 ` [U-Boot] [PATCH v4 3/3] Tegra: Config: Enable Tegra30/Tegra114 USB function Jim Lin
2013-06-20 11:17 ` [U-Boot] [PATCH v4 1/3] ARM: Tegra: FDT: Add USB EHCI function for T30/T114 Thierry Reding
2013-06-20 15:56 ` Stephen Warren [this message]
2013-06-20 16:00 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C32636.3040903@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox