From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 1/3] ARM: Tegra: FDT: Add USB EHCI function for T30/T114
Date: Thu, 20 Jun 2013 10:00:41 -0600 [thread overview]
Message-ID: <51C32729.8010400@wwwdotorg.org> (raw)
In-Reply-To: <1371716020-21809-1-git-send-email-jilin@nvidia.com>
On 06/20/2013 02:13 AM, Jim Lin wrote:
> Add DT node for USB EHCI function.
> Add support for T30-Cardhu, T30-Beaver, T114-Dalmore boards.
> diff --git a/arch/arm/dts/tegra114.dtsi b/arch/arm/dts/tegra114.dtsi
> + usb at 7d004000 {
> + compatible = "nvidia,tegra114-ehci";
> + reg = <0x7d004000 0x4000>;
> + interrupts = <53>;
> + phy_type = "utmi";
If Tegra114 and Tegra30 are anything like Tegra20, then USB2 doesn't
support UTMI mode; it's either ULPI or HSIC. Can you please check this.
The same comment applies in tegra30.dtsi.
> diff --git a/include/fdtdec.h b/include/fdtdec.h
> diff --git a/lib/fdtdec.c b/lib/fdtdec.c
As I said before, driver changes should be in a separate patch to DT
changes. Please move the changes to fdtdec.* into patch 2/3.
prev parent reply other threads:[~2013-06-20 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 8:13 [U-Boot] [PATCH v4 1/3] ARM: Tegra: FDT: Add USB EHCI function for T30/T114 Jim Lin
2013-06-20 8:13 ` [U-Boot] [PATCH v4 2/3] ARM: Tegra: USB: EHCI: Add support for Tegra30/Tegra114 Jim Lin
2013-06-20 16:19 ` Stephen Warren
2013-06-20 17:20 ` Jim Lin
2013-06-20 17:40 ` Stephen Warren
2013-06-20 8:13 ` [U-Boot] [PATCH v4 3/3] Tegra: Config: Enable Tegra30/Tegra114 USB function Jim Lin
2013-06-20 11:17 ` [U-Boot] [PATCH v4 1/3] ARM: Tegra: FDT: Add USB EHCI function for T30/T114 Thierry Reding
2013-06-20 15:56 ` Stephen Warren
2013-06-20 16:00 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C32729.8010400@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox