public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nand: Don't call adjust_size_for_badblocks for erase
Date: Fri, 21 Jun 2013 06:19:19 +0200	[thread overview]
Message-ID: <51C3D447.8000303@denx.de> (raw)
In-Reply-To: <1371750758-9589-1-git-send-email-scottwood@freescale.com>

Hello Scott,

Am 20.06.2013 19:52, schrieb Scott Wood:
> adjust_size_for_badblocks reduces the the operation size to account

nitpicking:
please only one "the".

> for the block skipping done by the read/write functions when an
> interval (partition name or whole chip) is specified rather than a data
> amount.
> 
> Erase does not do block skipping, except for erase.spread which takes
> a data amount rather than an interval (and thus already does not call
> adjust_size_for_badblocks).  Calling adjust_size_for_badblocks when
> block skipping is not done means that if bad blocks are present,
> the "nand erase.part" and "nand erase.chip" commands will fail to erase
> blocks at the end of the interval.
> 
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Cc: Harvey Chapman <hchapman@3gfp.com>
> ---
>  common/cmd_nand.c |    9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)

Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2013-06-21  4:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20 17:52 [U-Boot] [PATCH] nand: Don't call adjust_size_for_badblocks for erase Scott Wood
2013-06-21  4:19 ` Heiko Schocher [this message]
2013-06-21 16:48   ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C3D447.8000303@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox