[U-Boot] [PATCH] nand: Don't call adjust_size_for_badblocks for erase

Heiko Schocher
2013-06-21T04:19:19Z

Hello Scott,

Am 20.06.2013 19:52, schrieb Scott Wood:
> adjust_size_for_badblocks reduces the the operation size to account

nitpicking:
please only one "the".

> for the block skipping done by the read/write functions when an
> interval (partition name or whole chip) is specified rather than a data
> amount.
>
> Erase does not do block skipping, except for erase.spread which takes
> a data amount rather than an interval (and thus already does not call
> adjust_size_for_badblocks). Calling adjust_size_for_badblocks when
> block skipping is not done means that if bad blocks are present,
> the "nand erase.part" and "nand erase.chip" commands will fail to erase
> blocks at the end of the interval.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Cc: Harvey Chapman <hchapman@3gfp.com>
> ---
> common/cmd_nand.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)

Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany