[U-Boot] [U-Boot, v2] powerpc/mpc85xx:Disable Debug TLB entry before init_tlbs

Scott Wood
2013-06-21T21:12:03Z

On 06/21/2013 04:05:37 PM, Fleming Andy-AFLEMING wrote:
>
> On Jun 21, 2013, at 3:59 PM, Scott Wood wrote:
>
> > On 06/21/2013 03:38:48 PM, Andy Fleming wrote:
> >> On Thu, Jun 13, 2013 at 10:14:00AM +0530, Prabhakar Kushwaha wrote:
> >> > init_tlbs() initialize all the TLB entries required for the
> system.
> >> >
> >> > So disable DEBUG TLB entry before TLB entries initialization.
> >> >
> >> > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> >> Applied, with fixes.
> >> > diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> >> > index f4403c2..340b063 100644
> >> > --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> >> > +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> >> > @@ -180,5 +180,9 @@ void cpu_init_early_f(void)
> >> >
> >> > invalidate_tlb(1);
> >> >
> >> > +#if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) &&
> !defined(CONFIG_SPL_BUILD)
> >> > + disable_tlb(CONFIG_SYS_PPC_E500_DEBUG_TLB);
> >> > +#endif
> >> Had to add CONFIG_NAND_SPL here, as well, just for future reference
> >
> > Why exclude all SPLs? Only minimal SPLs skip creating the debug
> TLB.
>
> The definition of disable_tlb() is excluded when NAND_SPL is defined.

I'm talking about new-SPL, not NAND_SPL. My comment is about the
original patch (I made the comment before internally), not your edit to
it.

-Scott