public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] exynos: Adjust the starting MIF voltage to 1.05v
@ 2013-04-15 17:34 Bernie Thompson
  2013-05-11 18:50 ` Simon Glass
  0 siblings, 1 reply; 3+ messages in thread
From: Bernie Thompson @ 2013-04-15 17:34 UTC (permalink / raw)
  To: u-boot

Some Exynos5250 silicon may require 1.05v on the MIF to be stable, so to be
safe we can default to 1.05v instead of 1.00v. This can be set optimally later
in the boot process by the kernel.

The 0x6 value for 1.05v comes from the MAX77686 datasheet.

Signed-off-by: Bernie Thompson <bhthompson@chromium.org>
---
 board/samsung/smdk5250/smdk5250.c | 2 +-
 include/power/max77686_pmic.h     | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/board/samsung/smdk5250/smdk5250.c b/board/samsung/smdk5250/smdk5250.c
index 217c6df..2cea844 100644
--- a/board/samsung/smdk5250/smdk5250.c
+++ b/board/samsung/smdk5250/smdk5250.c
@@ -182,7 +182,7 @@ int power_init_board(void)
 
 	/* VDD_MIF */
 	if (pmic_reg_write(p, MAX77686_REG_PMIC_BUCK1OUT,
-						MAX77686_BUCK1OUT_1V)) {
+						MAX77686_BUCK1OUT_1_05V)) {
 		debug("%s: PMIC %d register write failed\n", __func__,
 						MAX77686_REG_PMIC_BUCK1OUT);
 		return -1;
diff --git a/include/power/max77686_pmic.h b/include/power/max77686_pmic.h
index fdc7ca9..1c374a9 100644
--- a/include/power/max77686_pmic.h
+++ b/include/power/max77686_pmic.h
@@ -157,6 +157,8 @@ enum {
 
 /* Buck1 1 volt value */
 #define MAX77686_BUCK1OUT_1V	0x5
+/* Buck1 1.05 volt value */
+#define MAX77686_BUCK1OUT_1_05V    0x6
 #define MAX77686_BUCK1CTRL_EN	(3 << 0)
 /* Buck2 1.3 volt value */
 #define MAX77686_BUCK2DVS1_1_3V	0x38
-- 
1.8.1.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] exynos: Adjust the starting MIF voltage to 1.05v
  2013-04-15 17:34 [U-Boot] [PATCH] exynos: Adjust the starting MIF voltage to 1.05v Bernie Thompson
@ 2013-05-11 18:50 ` Simon Glass
  2013-06-24  5:01   ` Minkyu Kang
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Glass @ 2013-05-11 18:50 UTC (permalink / raw)
  To: u-boot

On Mon, Apr 15, 2013 at 11:34 AM, Bernie Thompson
<bhthompson@chromium.org> wrote:
> Some Exynos5250 silicon may require 1.05v on the MIF to be stable, so to be
> safe we can default to 1.05v instead of 1.00v. This can be set optimally later
> in the boot process by the kernel.
>
> The 0x6 value for 1.05v comes from the MAX77686 datasheet.
>
> Signed-off-by: Bernie Thompson <bhthompson@chromium.org>

Acked-by: Simon Glass <sjg@chromium.org>

> ---
>  board/samsung/smdk5250/smdk5250.c | 2 +-
>  include/power/max77686_pmic.h     | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/board/samsung/smdk5250/smdk5250.c b/board/samsung/smdk5250/smdk5250.c
> index 217c6df..2cea844 100644
> --- a/board/samsung/smdk5250/smdk5250.c
> +++ b/board/samsung/smdk5250/smdk5250.c
> @@ -182,7 +182,7 @@ int power_init_board(void)
>
>         /* VDD_MIF */
>         if (pmic_reg_write(p, MAX77686_REG_PMIC_BUCK1OUT,
> -                                               MAX77686_BUCK1OUT_1V)) {
> +                                               MAX77686_BUCK1OUT_1_05V)) {
>                 debug("%s: PMIC %d register write failed\n", __func__,
>                                                 MAX77686_REG_PMIC_BUCK1OUT);
>                 return -1;
> diff --git a/include/power/max77686_pmic.h b/include/power/max77686_pmic.h
> index fdc7ca9..1c374a9 100644
> --- a/include/power/max77686_pmic.h
> +++ b/include/power/max77686_pmic.h
> @@ -157,6 +157,8 @@ enum {
>
>  /* Buck1 1 volt value */
>  #define MAX77686_BUCK1OUT_1V   0x5
> +/* Buck1 1.05 volt value */
> +#define MAX77686_BUCK1OUT_1_05V    0x6
>  #define MAX77686_BUCK1CTRL_EN  (3 << 0)
>  /* Buck2 1.3 volt value */
>  #define MAX77686_BUCK2DVS1_1_3V        0x38
> --
> 1.8.1.3
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] exynos: Adjust the starting MIF voltage to 1.05v
  2013-05-11 18:50 ` Simon Glass
@ 2013-06-24  5:01   ` Minkyu Kang
  0 siblings, 0 replies; 3+ messages in thread
From: Minkyu Kang @ 2013-06-24  5:01 UTC (permalink / raw)
  To: u-boot

On 12/05/13 03:50, Simon Glass wrote:
> On Mon, Apr 15, 2013 at 11:34 AM, Bernie Thompson
> <bhthompson@chromium.org> wrote:
>> Some Exynos5250 silicon may require 1.05v on the MIF to be stable, so to be
>> safe we can default to 1.05v instead of 1.00v. This can be set optimally later
>> in the boot process by the kernel.
>>
>> The 0x6 value for 1.05v comes from the MAX77686 datasheet.
>>
>> Signed-off-by: Bernie Thompson <bhthompson@chromium.org>
> 
> Acked-by: Simon Glass <sjg@chromium.org>
> 
>> ---
>>  board/samsung/smdk5250/smdk5250.c | 2 +-
>>  include/power/max77686_pmic.h     | 2 ++
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-06-24  5:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-15 17:34 [U-Boot] [PATCH] exynos: Adjust the starting MIF voltage to 1.05v Bernie Thompson
2013-05-11 18:50 ` Simon Glass
2013-06-24  5:01   ` Minkyu Kang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox