[U-Boot] [PATCH] LaCie kirkwood boards: allow disk > 2TB

Albert ARIBAUD
2013-06-10T14:48:25Z

Hi Simon,

On Mon, 10 Jun 2013 16:29:26 +0200, Simon Guinot
<simon.guinot@sequanux.org> wrote:

> On Mon, Jun 10, 2013 at 04:20:49PM +0200, Fr?d?ric Leroy wrote:
> >
> > Le 10/06/2013 15:44, Simon Guinot a ?crit :
> > > On Mon, Jun 10, 2013 at 03:30:53PM +0200, Frederic Leroy wrote:
> > > > From: Fr?d?ric Leroy <fredo@starox.org>
> > > >
> > > > For big disk support, we need LBA addressing on 64 bits
> > > > ---
> > > > include/configs/lacie_kw.h | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/include/configs/lacie_kw.h b/include/configs/lacie_kw.h
> > > > index 09b5798..847afcd 100644
> > > > --- a/include/configs/lacie_kw.h
> > > > +++ b/include/configs/lacie_kw.h
> > > > @@ -111,6 +111,7 @@
> > > > #define CONFIG_ENV_SPI_MAX_HZ 20000000 /* 20Mhz */
> > > > #define CONFIG_SYS_IDE_MAXBUS 1
> > > > #define CONFIG_SYS_IDE_MAXDEVICE 1
> > > > +#define CONFIG_SYS_64BIT_LBA /* Allow disk > 2.1TB */
> > >
> > > Hi Frederic,
> > >
> > > I see a comment at disk/part_efi.c:25. It claims that maximum size of
> > > addressable storage is limited to 2TB even with CONFIG_SYS_64BIT_LBA
> > > enabled. Is that not true anymore ?
> > I didn't see this comment.
> > With my patch, the "ide reset" command recognize nicely a 3TB harddrive.
> > Else, it reports the size % 2TB and then u-boot reports error in the GPT.
> >
> > I can read the GPT and boot from a loaded file from the first partition.
> > However, an "ext2ls" on a partition at the end of the disk outputs garbage.
> >
> > At least, the patch allow to use the first 2 TB for booting.
>
> Acked-by: Simon Guinot <simon.guinot@sequanux.org>
>
> I add Prafulla to the Cc recipient. He is the one who will pick your
> patch eventually.

Not necessarily, as this is only a target configuration change, not a
SoC change -- actually, nothing in the patch is related to Marvell SoCs.
This patch could go directly in mainline even, but usually I do the
picking up if it's an ARM target.

> Regards,
>
> Simon

Amicalement,
--
Albert.