From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 24 Jun 2013 15:31:36 -0400 Subject: [U-Boot] [PATCH 3/4] ARM: AM33xx: Move s_init to a common place In-Reply-To: <51C89B55.9020106@denx.de> References: <1372079722-19486-1-git-send-email-lokeshvutla@ti.com> <1372079722-19486-4-git-send-email-lokeshvutla@ti.com> <51C89B55.9020106@denx.de> Message-ID: <51C89E98.6040305@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/24/2013 03:17 PM, Heiko Schocher wrote: > Hello Lokesh, [snip] >> + /* Enable RTC32K clock */ + rtc32k_enable(); > > I tried your patches on my three boards. The board with the > rtc32k_enable() problem, did not work with them too :-( > > Maybe we make rtc32k_enable() weak in common code, and so I can > make a board specific (dummy) function? I'm not a big fan of this since without this kicked, you can't do PM. And we don't want to do it in the kernel as it takes a few seconds to settle. Kicking it in U-Boot means it will be settled by the time it's needed, if I recall things right. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRyJ6YAAoJENk4IS6UOR1WpRsP/id6+SDeuNpbq3+d2e4VXXii j4Wq9Sm0wKkzzg/TcDT3ycyp7EqfyaJnpYjRORMAUjNjVcGAqTrssYtnjYgTLZXS oAN9E4hv15bxUPJJs2+/aLsI8jaHQ8E6IzKI5qLfxOKZePMPhhXmCes4V4qrkpMQ BcwinNMgfcyiNhkiDX4MvdB/tnKpMddzK/3SjiokGvH7jESFUzxw26BzpOy6uD8j tFj4D/LRzRmGXp1YqdtdqIAy15oNmTmOfK9zwVDPKLs4NUDHLGBUE6sgQJ5JLxjT pbS3JzQLe57weuW7WbD6/2RN7sJXfeZR1OUgJxuSzw8JQVDvWpW+2BJLyzoyOO7x t2XeuVgEyNyEVBRDtoeQ42hLFyk3O5G/kvRfLqqH0jDFkQKkMXMBhs2Bo4HA+157 o+HbB7GZkwR5ZKx+8RqmhP9t+IQjb1A8dkD/4gA0U0bYhbj4XhJSsDYtw1DMjya2 gr19m4n0qaRcwsRWZKX0ZahcxqWFWoRiNFxIBOeFSpeilR9dxEA3xE9VMC0jTSKA 1Wgi+cyRICTqXFhhpNinK79aszHEVBcU+A1ZgmHtpvZ2UNh4V+uXE0ydWMLw61gT ZHfB96WmFWQItu40/DN9Fo3JbJcGPtRHoR9yYV52WFszFml6p5+y6BHrNQ6D0a7l 2/4y5iHiZ7b8xpQKZbAp =ZwYD -----END PGP SIGNATURE-----