From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Mon, 24 Jun 2013 21:44:28 +0200 Subject: [U-Boot] [PATCH 3/4] ARM: AM33xx: Move s_init to a common place In-Reply-To: <51C89E98.6040305@ti.com> References: <1372079722-19486-1-git-send-email-lokeshvutla@ti.com> <1372079722-19486-4-git-send-email-lokeshvutla@ti.com> <51C89B55.9020106@denx.de> <51C89E98.6040305@ti.com> Message-ID: <51C8A19C.6020808@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Tom, Am 24.06.2013 21:31, schrieb Tom Rini: > On 06/24/2013 03:17 PM, Heiko Schocher wrote: >> Hello Lokesh, > [snip] >>> + /* Enable RTC32K clock */ + rtc32k_enable(); > >> I tried your patches on my three boards. The board with the >> rtc32k_enable() problem, did not work with them too :-( > >> Maybe we make rtc32k_enable() weak in common code, and so I can >> make a board specific (dummy) function? > > I'm not a big fan of this since without this kicked, you can't do PM. > And we don't want to do it in the kernel as it takes a few seconds to > settle. Kicking it in U-Boot means it will be settled by the time > it's needed, if I recall things right. Hmm.. but on my board, the cpu hangs (not accessible through bdi anymore) if I access this registers ... looking still for an explanation ... Clocks are enabled, 24MHz (same as on am335x eval board) used ... I know, this is only a bugfix, without knowing the real reason ... bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany