* [U-Boot] [PATCH] gpio: s3c2440_gpio: Fix wrong writel arguments
@ 2013-06-15 9:56 Axel Lin
2013-06-15 12:36 ` Marek Vasut
2013-06-25 1:58 ` Minkyu Kang
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-06-15 9:56 UTC (permalink / raw)
To: u-boot
Current code had writel arguments the wrong way around, fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi,
I don't have this hardware to test, but current code looks obviously wrong.
I'd appreciate if someone can review and test this patch.
Axel
drivers/gpio/s3c2440_gpio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/s3c2440_gpio.c b/drivers/gpio/s3c2440_gpio.c
index 43bbf11..09b04eb 100644
--- a/drivers/gpio/s3c2440_gpio.c
+++ b/drivers/gpio/s3c2440_gpio.c
@@ -61,7 +61,7 @@ int gpio_set_value(unsigned gpio, int value)
else
l &= ~bit;
- return writel(port, l);
+ return writel(l, port);
}
int gpio_get_value(unsigned gpio)
@@ -85,11 +85,11 @@ int gpio_free(unsigned gpio)
int gpio_direction_input(unsigned gpio)
{
- return writel(GPIO_FULLPORT(gpio), GPIO_INPUT << GPIO_BIT(gpio));
+ return writel(GPIO_INPUT << GPIO_BIT(gpio), GPIO_FULLPORT(gpio));
}
int gpio_direction_output(unsigned gpio, int value)
{
- writel(GPIO_FULLPORT(gpio), GPIO_OUTPUT << GPIO_BIT(gpio));
+ writel(GPIO_OUTPUT << GPIO_BIT(gpio), GPIO_FULLPORT(gpio));
return gpio_set_value(gpio, value);
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] gpio: s3c2440_gpio: Fix wrong writel arguments
2013-06-15 9:56 [U-Boot] [PATCH] gpio: s3c2440_gpio: Fix wrong writel arguments Axel Lin
@ 2013-06-15 12:36 ` Marek Vasut
2013-06-25 1:58 ` Minkyu Kang
1 sibling, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2013-06-15 12:36 UTC (permalink / raw)
To: u-boot
Dear Axel Lin,
> Current code had writel arguments the wrong way around, fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi,
> I don't have this hardware to test, but current code looks obviously wrong.
> I'd appreciate if someone can review and test this patch.
>
> Axel
> drivers/gpio/s3c2440_gpio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] gpio: s3c2440_gpio: Fix wrong writel arguments
2013-06-15 9:56 [U-Boot] [PATCH] gpio: s3c2440_gpio: Fix wrong writel arguments Axel Lin
2013-06-15 12:36 ` Marek Vasut
@ 2013-06-25 1:58 ` Minkyu Kang
1 sibling, 0 replies; 3+ messages in thread
From: Minkyu Kang @ 2013-06-25 1:58 UTC (permalink / raw)
To: u-boot
On 15/06/13 18:56, Axel Lin wrote:
> Current code had writel arguments the wrong way around, fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi,
> I don't have this hardware to test, but current code looks obviously wrong.
> I'd appreciate if someone can review and test this patch.
>
> Axel
> drivers/gpio/s3c2440_gpio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/s3c2440_gpio.c b/drivers/gpio/s3c2440_gpio.c
> index 43bbf11..09b04eb 100644
> --- a/drivers/gpio/s3c2440_gpio.c
> +++ b/drivers/gpio/s3c2440_gpio.c
> @@ -61,7 +61,7 @@ int gpio_set_value(unsigned gpio, int value)
> else
> l &= ~bit;
>
> - return writel(port, l);
> + return writel(l, port);
> }
>
> int gpio_get_value(unsigned gpio)
> @@ -85,11 +85,11 @@ int gpio_free(unsigned gpio)
>
> int gpio_direction_input(unsigned gpio)
> {
> - return writel(GPIO_FULLPORT(gpio), GPIO_INPUT << GPIO_BIT(gpio));
> + return writel(GPIO_INPUT << GPIO_BIT(gpio), GPIO_FULLPORT(gpio));
> }
>
> int gpio_direction_output(unsigned gpio, int value)
> {
> - writel(GPIO_FULLPORT(gpio), GPIO_OUTPUT << GPIO_BIT(gpio));
> + writel(GPIO_OUTPUT << GPIO_BIT(gpio), GPIO_FULLPORT(gpio));
> return gpio_set_value(gpio, value);
> }
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-25 1:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-15 9:56 [U-Boot] [PATCH] gpio: s3c2440_gpio: Fix wrong writel arguments Axel Lin
2013-06-15 12:36 ` Marek Vasut
2013-06-25 1:58 ` Minkyu Kang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox