From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] gpio: s5p_gpio: Call s5p_gpio_set_value() instead of open-code
Date: Tue, 25 Jun 2013 10:58:47 +0900 [thread overview]
Message-ID: <51C8F957.5090209@samsung.com> (raw)
In-Reply-To: <1371305985.27690.2.camel@phoenix>
On 15/06/13 23:19, Axel Lin wrote:
> Call s5p_gpio_set_value() to avoid code duplication.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/gpio/s5p_gpio.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/gpio/s5p_gpio.c b/drivers/gpio/s5p_gpio.c
> index 656bf4a..4efb768 100644
> --- a/drivers/gpio/s5p_gpio.c
> +++ b/drivers/gpio/s5p_gpio.c
> @@ -48,15 +48,8 @@ void s5p_gpio_cfg_pin(struct s5p_gpio_bank *bank, int gpio, int cfg)
>
> void s5p_gpio_direction_output(struct s5p_gpio_bank *bank, int gpio, int en)
> {
> - unsigned int value;
> -
> s5p_gpio_cfg_pin(bank, gpio, GPIO_OUTPUT);
> -
> - value = readl(&bank->dat);
> - value &= ~DAT_MASK(gpio);
> - if (en)
> - value |= DAT_SET(gpio);
> - writel(value, &bank->dat);
> + s5p_gpio_set_value(bank, gpio, en);
> }
>
> void s5p_gpio_direction_input(struct s5p_gpio_bank *bank, int gpio)
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
prev parent reply other threads:[~2013-06-25 1:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-15 14:19 [U-Boot] [PATCH] gpio: s5p_gpio: Call s5p_gpio_set_value() instead of open-code Axel Lin
2013-06-25 1:58 ` Minkyu Kang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C8F957.5090209@samsung.com \
--to=mk7.kang@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox