From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minkyu Kang Date: Tue, 25 Jun 2013 10:58:47 +0900 Subject: [U-Boot] [PATCH] gpio: s5p_gpio: Call s5p_gpio_set_value() instead of open-code In-Reply-To: <1371305985.27690.2.camel@phoenix> References: <1371305985.27690.2.camel@phoenix> Message-ID: <51C8F957.5090209@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 15/06/13 23:19, Axel Lin wrote: > Call s5p_gpio_set_value() to avoid code duplication. > > Signed-off-by: Axel Lin > --- > drivers/gpio/s5p_gpio.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/gpio/s5p_gpio.c b/drivers/gpio/s5p_gpio.c > index 656bf4a..4efb768 100644 > --- a/drivers/gpio/s5p_gpio.c > +++ b/drivers/gpio/s5p_gpio.c > @@ -48,15 +48,8 @@ void s5p_gpio_cfg_pin(struct s5p_gpio_bank *bank, int gpio, int cfg) > > void s5p_gpio_direction_output(struct s5p_gpio_bank *bank, int gpio, int en) > { > - unsigned int value; > - > s5p_gpio_cfg_pin(bank, gpio, GPIO_OUTPUT); > - > - value = readl(&bank->dat); > - value &= ~DAT_MASK(gpio); > - if (en) > - value |= DAT_SET(gpio); > - writel(value, &bank->dat); > + s5p_gpio_set_value(bank, gpio, en); > } > > void s5p_gpio_direction_input(struct s5p_gpio_bank *bank, int gpio) > applied to u-boot-samsung. Thanks, Minkyu Kang.