From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 25 Jun 2013 08:47:34 -0600 Subject: [U-Boot] [PATCH V2 1/9] Validate dtc is new enough In-Reply-To: References: <1372088629-14134-1-git-send-email-swarren@wwwdotorg.org> <1372088629-14134-2-git-send-email-swarren@wwwdotorg.org> Message-ID: <51C9AD86.4050602@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 06/24/2013 06:45 PM, Simon Glass wrote: > Hi Stephen, > > On Mon, Jun 24, 2013 at 8:43 AM, Stephen Warren > wrote: > > From: Stephen Warren > > > Subsequent patches assume that dtc supports various recent features. > These are available in dtc 1.4.0. Validate that dtc is at least that > version. > > Acked-by: Simon Glass > > > See note below. > diff --git a/Makefile b/Makefile > -$(obj)u-boot.dtb: $(obj)u-boot > +$(obj)u-boot.dtb: checkdtc $(obj)u-boot > > > Any reason this is not in dts/Makefile? Still this is fine. I guess that would have worked too. One advantage of the current placement is that make just happens to evaluate the rule really early (at least with more than -j1!), so you don't build a lot before it errors out, thus giving you quicker feedback. It also keeps all the tool version checks in one file; perhaps easier maintenance?