From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Date: Wed, 26 Jun 2013 00:39:13 +0200 Subject: [U-Boot] [PATCH v5 3/8] GPIO: add Dove support to Kirkwood GPIO driver In-Reply-To: <1372195668-25496-4-git-send-email-t-uboot@infra-silbe.de> References: <51C9F64B.1020107@gmail.com> <1372195668-25496-1-git-send-email-t-uboot@infra-silbe.de> <1372195668-25496-4-git-send-email-t-uboot@infra-silbe.de> Message-ID: <51CA1C11.2000700@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 06/25/2013 11:27 PM, Sascha Silbe wrote: > The GPIO support of Dove is very similar to that on Kirkwood (and > possibly orion5x as well). Instead of duplicating the code, we tweak > the Kirkwood driver so it works for Dove, too. > > Signed-off-by: Sascha Silbe > --- [...] > diff --git a/drivers/gpio/kw_gpio.c b/drivers/gpio/kw_gpio.c > index 51a826d..d6fdb69 100644 > --- a/drivers/gpio/kw_gpio.c > +++ b/drivers/gpio/kw_gpio.c > @@ -1,7 +1,11 @@ > /* > - * arch/arm/plat-orion/gpio.c > + * Marvell Dove and Kirkwood SoC GPIO handling > * > - * Marvell Orion SoC GPIO handling. > + * Sebastian Hesselbarth > + * > + * Based on (mostly copied from) plat-orion based Linux 2.6 kernel driver. > + * Removed orion_gpiochip struct and kernel level irq handling. > + * Dieter Kiermaier dk-arm-linux at gmx.de > * [...] > int kw_gpio_is_valid(unsigned pin, int mode) > @@ -88,7 +88,7 @@ int kw_gpio_is_valid(unsigned pin, int mode) > } > > err_out: > - printf("%s: invalid GPIO %d\n", __func__, pin); > + printf("%s: invalid GPIO %d/%d\n", __func__, pin, GPIO_MAX); nit: indent with TAB Sebastian