public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] SMDK5250: Remove reduntant code
Date: Fri, 28 Jun 2013 09:20:24 +0900	[thread overview]
Message-ID: <51CCD6C8.7060604@samsung.com> (raw)
In-Reply-To: <1372168026-5741-1-git-send-email-rajeshwari.s@samsung.com>

On 25/06/13 22:47, Rajeshwari Shinde wrote:
> enum boot_mode is defined twice once in spl.h and also in
> spl_boot.c, hence removing the same from spl_boot.c and including
> the header file.
> 
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
>  arch/arm/include/asm/arch-exynos/spl.h |    1 +
>  board/samsung/smdk5250/spl_boot.c      |   10 +---------
>  2 files changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/include/asm/arch-exynos/spl.h b/arch/arm/include/asm/arch-exynos/spl.h
> index 46b25a6..59bb7e0 100644
> --- a/arch/arm/include/asm/arch-exynos/spl.h
> +++ b/arch/arm/include/asm/arch-exynos/spl.h
> @@ -32,6 +32,7 @@ enum boot_mode {
>  	 * pin values are the same across Exynos4 and Exynos5.
>  	 */
>  	BOOT_MODE_MMC = 4,
> +	BOOT_MODE_EMMC = 8,     /* EMMC4.4 */
>  	BOOT_MODE_SERIAL = 20,
>  	/* Boot based on Operating Mode pin settings */
>  	BOOT_MODE_OM = 32,
> diff --git a/board/samsung/smdk5250/spl_boot.c b/board/samsung/smdk5250/spl_boot.c
> index 98f2286..83275f1 100644
> --- a/board/samsung/smdk5250/spl_boot.c
> +++ b/board/samsung/smdk5250/spl_boot.c
> @@ -26,6 +26,7 @@
>  #include <asm/arch-exynos/dmc.h>
>  #include <asm/arch/clock.h>
>  #include <asm/arch/clk.h>
> +#include <asm/arch/spl.h>
>  
>  #include "clock_init.h"
>  
> @@ -48,15 +49,6 @@ u32 irom_ptr_table[] = {
>  	[USB_INDEX] = 0x02020070,	/* iROM Function Pointer-USB boot*/
>  	};
>  
> -enum boot_mode {
> -	BOOT_MODE_MMC = 4,
> -	BOOT_MODE_SERIAL = 20,
> -	BOOT_MODE_EMMC = 8,     /* EMMC4.4 */
> -	/* Boot based on Operating Mode pin settings */
> -	BOOT_MODE_OM = 32,
> -	BOOT_MODE_USB,	/* Boot using USB download */
> -};
> -
>  void *get_irom_func(int index)
>  {
>  	return (void *)*(u32 *)irom_ptr_table[index];
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

      parent reply	other threads:[~2013-06-28  0:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-25 13:47 [U-Boot] [PATCH] SMDK5250: Remove reduntant code Rajeshwari Shinde
2013-06-25 13:55 ` Simon Glass
2013-06-27  9:17   ` Rajeshwari Birje
2013-06-28  0:20 ` Minkyu Kang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51CCD6C8.7060604@samsung.com \
    --to=mk7.kang@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox