From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mkimage: Build signing only if board has CONFIG_FIT_SIGNATURE
Date: Fri, 28 Jun 2013 08:48:48 +0200 [thread overview]
Message-ID: <51CD31D0.8050905@googlemail.com> (raw)
In-Reply-To: <1372354998-22542-1-git-send-email-sjg@chromium.org>
Hi Simon,
On 27.06.13 19:43, Simon Glass wrote:
> At present mkimage is set up to always build with image signing support.
> This means that the SSL libraries (e.g. libssl-dev) are always required.
>
> Adjust things so that mkimage can be built with and without image signing,
> controlled by the presence of CONFIG_FIT_SIGNATURE in the board config file.
>
> If CONFIG_FIT_SIGNATURE is not enabled, then mkimage will report a warning
> that signing is not supported. If the option is enabled, but libraries are
> not available, then a build error similar to this will be shown:
>
> lib/rsa/rsa-sign.c:26:25: fatal error: openssl/rsa.h: No such file or directory
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> config.mk | 6 +++++-
> include/image.h | 3 ---
> tools/Makefile | 2 +-
> 3 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/config.mk b/config.mk
> index 5a91203..81c2584 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -96,7 +96,6 @@ HOSTCFLAGS += $(call os_x_before, 10, 4, "-traditional-cpp")
> HOSTLDFLAGS += $(call os_x_before, 10, 5, "-multiply_defined suppress")
> else
> HOSTCC = gcc
> -HOSTLIBS += -lssl -lcrypto
> endif
>
> ifeq ($(HOSTOS),cygwin)
> @@ -211,6 +210,11 @@ CPPFLAGS += -ffunction-sections -fdata-sections
> LDFLAGS_FINAL += --gc-sections
> endif
>
> +# TODO(sjg at chromium.org): Is this correct on Mac OS?
I'll check it these days. Unfortunately regex is behaving differently on
OS X too, so prooftool.c is not compiling:
---8<---
proftool.c: In function ?check_trace_config_line?:
proftool.c:336: error: ?REG_NOERROR? undeclared (first use in this function)
--->8---
I'll check this too.
Best regards
Andreas Bie?mann
next prev parent reply other threads:[~2013-06-28 6:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 17:43 [U-Boot] [PATCH] mkimage: Build signing only if board has CONFIG_FIT_SIGNATURE Simon Glass
2013-06-27 20:55 ` Albert ARIBAUD
2013-06-27 21:47 ` Tom Rini
2013-06-28 6:48 ` Andreas Bießmann [this message]
2013-06-28 6:52 ` Simon Glass
2013-06-28 7:02 ` Andreas Bießmann
2013-06-28 7:11 ` Simon Glass
2013-06-28 8:21 ` Lubomir Popov
2013-06-28 7:00 ` [U-Boot] [PATCH] lib/rsa/rsa-sig.c: compile on OS X Andreas Bießmann
2013-06-30 13:08 ` Andreas Bießmann
2013-06-28 22:07 ` [U-Boot] [PATCH] mkimage: Build signing only if board has CONFIG_FIT_SIGNATURE Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CD31D0.8050905@googlemail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox