From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Fri, 28 Jun 2013 15:11:59 +0200 Subject: [U-Boot] [PATCH] Fix bootm to work on powerpc again (compressed uImage) In-Reply-To: <20130628130322.GH28078@bill-the-cat> References: <1372406523-5726-1-git-send-email-sr@denx.de> <20130628130322.GH28078@bill-the-cat> Message-ID: <51CD8B9F.3070207@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 06/28/2013 03:03 PM, Tom Rini wrote: >> Patch 35fc84fa1 [Refactor the bootm command to reduce code duplication] >> breaks booting Linux (compressed uImage with fdt) on powerpc. >> >> boot_jump_linux() mustn't be called before boot_prep_linux() and >> boot_body_linux() have been called. So remove the superfluous call >> to boot_jump_linux() in arch/powerpc/lib/bootm.c as its called later on >> in this function. >> >> Signed-off-by: Stefan Roese >> Cc: Simon Glass >> Cc: Tom Rini >> --- >> Simon, I'm not 100% sure why this is triggered by your patch. >> >> As you see, my patch only fixes powerpc. ARM might have the same problem >> as it has the same code duplication in bootm.c. > > Progress! On PowerPC, does bootm work like before? Yes. I'm using the same environment (boot_cmd) as before. And without this patch "bootm kernel_addr - fdt_addr' hangs. I might only affect DT booting, as without this patch boot_jump_linux() is called without calling boot_prep_linux() and boot_body_linux() before. One of those (I didn't check which one) is responsible for this line: Loading Device Tree to 007f8000, end 007ffdd4 ... OK And this is missing when this patch is not applied. Thanks, Stefan