From: "Frédéric Leroy" <fredo@starox.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/4] arm: add machine ID for CloudBox
Date: Mon, 01 Jul 2013 11:30:01 +0200 [thread overview]
Message-ID: <51D14C19.3040208@starox.org> (raw)
In-Reply-To: <20130630225321.GC10726@kw.sim.vm.gnt>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Le 01/07/2013 00:53, Simon Guinot a ?crit :
> On Sun, Jun 30, 2013 at 12:12:29PM +0200, Fr?d?ric Leroy wrote:
> > CloudBox device is device tree compliant, but older LaCie kernel uses
> > machine ID method to boot.
> >
> > Signed-off-by: Fr?d?ric Leroy <fredo@starox.org>
> > [...]
> > +# define machine_cloudbox() (0)
> > +#endif
>
> Hi Fred,
>
> I think you can't update this file directly. Pulling the Linux mach-types
> file is the ARM maintainer job.
>
> Note that for the CloudBox board, the mach-types entry has been removed
> because not needed by Linux. The Linux mainline support is only based on
> DT. I had the same issue with the ns2 lite and mini. At the time, I have
> been told to include the machine ID in the board header:
> http://marc.info/?l=u-boot&m=134694402011372&w=2
>
> Looks in configs/lacie_kw.h and grep for "missing in mach-types.h".
There is a doublon for netspace_lite_v2 :
$ git grep MACH_TYPE_NETSPACE_
arch/arm/include/asm/mach-types.h:#define MACH_TYPE_NETSPACE_LITE_V2
2983
[...]
include/configs/lacie_kw.h:#define MACH_TYPE_NETSPACE_LITE_V2 2983 /*
missing in mach-types.h */
> Besides, I don't understand why do you need a separate patch to add the
> legacy boot support.
Partly because I added CloudBox without it and it seems logical to add
it after,
partly because I was not sure of the change of mach_types.h :)
I am not at ease with sending patch to the ML and with patchwork.
How should I send the fix ?
A new v3 patch including all but " lacie_kw: sort #ifdef lists by
CONFIG_ identifiers"
and "LaCie/common: Fix cloudbox ethernet leds",
or just a v3 of "arm: add machine ID for CloudBox" ?
- --
Fr?d?ric
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQGcBAEBAgAGBQJR0UwZAAoJEJVX96CfzRSesw8MAKpUfwRAwe8beLAuHUf1xWTh
XksHGVuWOoI/lyAuz8AxcnE/EjbzliLGV0k0qDsWxlmVga425VxrY8d5/qZL55Z8
F95yo0aZ1q3EPTaSwjKVTUntJm8WOJesf6cK3YQqTO/1b+hrP+NCGBFL4+vNFPPL
9jtKkMjhOSa+f6X/fIhcCiqATUkX22SRheX7osoLxHFOTQ8baJLxf2Bt0L/g2KRA
t36WCYAqENx727LUIYdT3+B9tEEpc2fpCma2CRMmDjKgFrdbyOik/B7+mtk6Pyla
xoXQs7rV2OBYUYV2CBwQKfqBHIhrqazWcA+a5M13P90xyLjWJ/RoTAs/a9iMHNwO
xyvaDCafIJBloq+GXlkwewQfxZ2AkKADP+Q47hGkYYX8YOCOJ4bz+OQ/UT/M+LJK
pg0LBwjj8CUI6FpdxJWvDvxORpBFHPxDXjuz/rMenblph0cAEJH4O9BOlVUUkahw
E7/W9U0koVaEKg6Uegmuert1SSDSJwBHRdB+tXljMg==
=dDRp
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-07-01 9:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 16:49 [U-Boot] [PATCH 0/2] add support for LaCie CloudBox Frederic Leroy
2013-06-25 16:49 ` [U-Boot] [PATCH 1/2] arm: " Frederic Leroy
2013-06-25 18:24 ` Wolfgang Denk
2013-06-30 10:12 ` [U-Boot] [PATCH v2 0/4] " Frédéric Leroy
2013-06-30 10:12 ` [U-Boot] [PATCH v2 1/4] lacie_kw: sort #ifdef lists by CONFIG_ identifiers Frédéric Leroy
2013-06-30 22:15 ` Simon Guinot
2013-06-30 10:12 ` [U-Boot] [PATCH v2 2/4] arm: add support for LaCie CloudBox Frédéric Leroy
2013-06-30 10:12 ` [U-Boot] [PATCH v2 3/4] LaCie/common: Fix cloudbox ethernet leds Frédéric Leroy
2013-06-30 23:01 ` Simon Guinot
2013-07-01 9:51 ` [U-Boot] compiled failed when turned off gcc optimazition TigerLiu at viatech.com.cn
2013-07-01 10:03 ` Wolfgang Denk
2013-07-01 10:08 ` TigerLiu at viatech.com.cn
2013-07-01 11:37 ` Wolfgang Denk
2013-07-01 18:03 ` Mike Dunn
2013-07-01 19:51 ` Wolfgang Denk
2013-07-02 19:40 ` Mike Dunn
2013-07-02 22:38 ` Graeme Russ
2013-07-05 10:31 ` TigerLiu at viatech.com.cn
2013-07-05 14:00 ` [U-Boot] compiled failed when turned off gcc optimazitionAT Albert ARIBAUD
2013-06-30 10:12 ` [U-Boot] [PATCH v2 4/4] arm: add machine ID for CloudBox Frédéric Leroy
2013-06-30 22:53 ` Simon Guinot
2013-07-01 9:30 ` Frédéric Leroy [this message]
2013-07-01 10:01 ` Simon Guinot
2013-06-25 20:50 ` [U-Boot] [PATCH 1/2] arm: add support for LaCie CloudBox Simon Guinot
2013-06-25 21:09 ` Simon Guinot
2013-06-25 16:49 ` [U-Boot] [PATCH 2/2] LaCie/common: Fix cloudbox ethernet leds Frederic Leroy
2013-06-25 18:27 ` Wolfgang Denk
2013-06-25 21:08 ` Simon Guinot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D14C19.3040208@starox.org \
--to=fredo@starox.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox