* [U-Boot] [PATCH] Origen: Correct equation to calculate PLL output frequency
@ 2013-07-01 7:42 Rajeshwari Shinde
2013-07-01 8:26 ` Minkyu Kang
0 siblings, 1 reply; 4+ messages in thread
From: Rajeshwari Shinde @ 2013-07-01 7:42 UTC (permalink / raw)
To: u-boot
EXYNOS4 user manual equation for calculating PLL output is
FOUT= MDIV x FIN/(PDIV x 2^(SDIV -1))
hence updating accordingly.
Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
---
arch/arm/cpu/armv7/exynos/clock.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/arch/arm/cpu/armv7/exynos/clock.c b/arch/arm/cpu/armv7/exynos/clock.c
index e1c4246..af0fa5b 100644
--- a/arch/arm/cpu/armv7/exynos/clock.c
+++ b/arch/arm/cpu/armv7/exynos/clock.c
@@ -116,8 +116,15 @@ static int exynos_get_pll_clk(int pllreg, unsigned int r, unsigned int k)
/* FOUT = (MDIV + K / 1024) * FIN / (PDIV * 2^SDIV) */
fout = (m + k / 1024) * (freq / (p * (1 << s)));
} else {
- /* FOUT = MDIV * FIN / (PDIV * 2^SDIV) */
- fout = m * (freq / (p * (1 << s)));
+ if (cpu_is_exynos4()) {
+ if (s < 1)
+ s = 1;
+ /* FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1)) */
+ fout = m * (freq / (p * (1 << (s - 1))));
+ } else {
+ /* FOUT = MDIV * FIN / (PDIV * 2^SDIV) */
+ fout = m * (freq / (p * (1 << s)));
+ }
}
return fout;
--
1.7.4.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] Origen: Correct equation to calculate PLL output frequency
2013-07-01 7:42 [U-Boot] [PATCH] Origen: Correct equation to calculate PLL output frequency Rajeshwari Shinde
@ 2013-07-01 8:26 ` Minkyu Kang
2013-07-01 8:41 ` Rajeshwari Birje
0 siblings, 1 reply; 4+ messages in thread
From: Minkyu Kang @ 2013-07-01 8:26 UTC (permalink / raw)
To: u-boot
On 01/07/13 16:42, Rajeshwari Shinde wrote:
> EXYNOS4 user manual equation for calculating PLL output is
> FOUT= MDIV x FIN/(PDIV x 2^(SDIV -1))
> hence updating accordingly.
>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
> arch/arm/cpu/armv7/exynos/clock.c | 11 +++++++++--
> 1 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/exynos/clock.c b/arch/arm/cpu/armv7/exynos/clock.c
> index e1c4246..af0fa5b 100644
> --- a/arch/arm/cpu/armv7/exynos/clock.c
> +++ b/arch/arm/cpu/armv7/exynos/clock.c
> @@ -116,8 +116,15 @@ static int exynos_get_pll_clk(int pllreg, unsigned int r, unsigned int k)
> /* FOUT = (MDIV + K / 1024) * FIN / (PDIV * 2^SDIV) */
> fout = (m + k / 1024) * (freq / (p * (1 << s)));
> } else {
> - /* FOUT = MDIV * FIN / (PDIV * 2^SDIV) */
> - fout = m * (freq / (p * (1 << s)));
> + if (cpu_is_exynos4()) {
> + if (s < 1)
> + s = 1;
> + /* FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1)) */
> + fout = m * (freq / (p * (1 << (s - 1))));
> + } else {
> + /* FOUT = MDIV * FIN / (PDIV * 2^SDIV) */
> + fout = m * (freq / (p * (1 << s)));
> + }
> }
>
> return fout;
>
I checked about it.
It was wrong, but your patch doesn't fit too.
exynos4210
FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1))
exynos4412
FOUT = MDIV * FIN / (PDIV * 2^SDIV)
exynos5250
FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1))
At past, our code was,
FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1))
It was changed by Akshay's patch.
commit 234370cab4b2f096e095fe8f3284fd39740a4023
Author: Akshay Saraswat <akshay.s@samsung.com>
Date: Fri Mar 22 02:26:36 2013 +0000
Exynos5: clock: Update the equation to calculate PLL output frequency
According to the latest exynos5 user manual, the equation for
calculating PLL output was changed to
FOUT= MDIV x FIN/(PDIV x 2^SDIV)
earlier it was
FOUT= MDIV x FIN/(PDIV x 2^(SDIV -1))
So updating the clock code accordingly.
Signed-off-by: Hatim Ali <hatim.rv@samsung.com>
Signed-off-by: Akshay Saraswat <akshay.s@samsung.com>
Acked-by: Simon Glass <sjg@chromium.org>
According to Akshay's patch.
exynos5250 should be
FOUT = MDIV * FIN / (PDIV * 2^SDIV)
but my manual (I'm not sure that is latest version) shows
FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1))
Akshay,
please check this.
Rajeshwari,
Thank you for raise this issue,
I'll check it and resend the patch.
Thanks,
Minkyu Kang.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] Origen: Correct equation to calculate PLL output frequency
2013-07-01 8:26 ` Minkyu Kang
@ 2013-07-01 8:41 ` Rajeshwari Birje
2013-07-02 6:45 ` Minkyu Kang
0 siblings, 1 reply; 4+ messages in thread
From: Rajeshwari Birje @ 2013-07-01 8:41 UTC (permalink / raw)
To: u-boot
Hi Minkyu Kang,
As per the user manual I have for EXYNOS5 it is
FOUT = MDIV * FIN / (PDIV * 2^SDIV)
Regards,
Rajeshwari Shinde.
On Mon, Jul 1, 2013 at 1:56 PM, Minkyu Kang <mk7.kang@samsung.com> wrote:
> On 01/07/13 16:42, Rajeshwari Shinde wrote:
>> EXYNOS4 user manual equation for calculating PLL output is
>> FOUT= MDIV x FIN/(PDIV x 2^(SDIV -1))
>> hence updating accordingly.
>>
>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>> ---
>> arch/arm/cpu/armv7/exynos/clock.c | 11 +++++++++--
>> 1 files changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/cpu/armv7/exynos/clock.c b/arch/arm/cpu/armv7/exynos/clock.c
>> index e1c4246..af0fa5b 100644
>> --- a/arch/arm/cpu/armv7/exynos/clock.c
>> +++ b/arch/arm/cpu/armv7/exynos/clock.c
>> @@ -116,8 +116,15 @@ static int exynos_get_pll_clk(int pllreg, unsigned int r, unsigned int k)
>> /* FOUT = (MDIV + K / 1024) * FIN / (PDIV * 2^SDIV) */
>> fout = (m + k / 1024) * (freq / (p * (1 << s)));
>> } else {
>> - /* FOUT = MDIV * FIN / (PDIV * 2^SDIV) */
>> - fout = m * (freq / (p * (1 << s)));
>> + if (cpu_is_exynos4()) {
>> + if (s < 1)
>> + s = 1;
>> + /* FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1)) */
>> + fout = m * (freq / (p * (1 << (s - 1))));
>> + } else {
>> + /* FOUT = MDIV * FIN / (PDIV * 2^SDIV) */
>> + fout = m * (freq / (p * (1 << s)));
>> + }
>> }
>>
>> return fout;
>>
>
> I checked about it.
> It was wrong, but your patch doesn't fit too.
>
> exynos4210
> FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1))
>
> exynos4412
> FOUT = MDIV * FIN / (PDIV * 2^SDIV)
>
> exynos5250
> FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1))
>
> At past, our code was,
> FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1))
> It was changed by Akshay's patch.
>
>
> commit 234370cab4b2f096e095fe8f3284fd39740a4023
> Author: Akshay Saraswat <akshay.s@samsung.com>
> Date: Fri Mar 22 02:26:36 2013 +0000
>
> Exynos5: clock: Update the equation to calculate PLL output frequency
>
> According to the latest exynos5 user manual, the equation for
> calculating PLL output was changed to
> FOUT= MDIV x FIN/(PDIV x 2^SDIV)
> earlier it was
> FOUT= MDIV x FIN/(PDIV x 2^(SDIV -1))
> So updating the clock code accordingly.
>
> Signed-off-by: Hatim Ali <hatim.rv@samsung.com>
> Signed-off-by: Akshay Saraswat <akshay.s@samsung.com>
> Acked-by: Simon Glass <sjg@chromium.org>
>
>
> According to Akshay's patch.
> exynos5250 should be
> FOUT = MDIV * FIN / (PDIV * 2^SDIV)
> but my manual (I'm not sure that is latest version) shows
> FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1))
>
> Akshay,
> please check this.
>
> Rajeshwari,
> Thank you for raise this issue,
> I'll check it and resend the patch.
>
> Thanks,
> Minkyu Kang.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
--
Regards,
Rajeshwari Shinde
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] Origen: Correct equation to calculate PLL output frequency
2013-07-01 8:41 ` Rajeshwari Birje
@ 2013-07-02 6:45 ` Minkyu Kang
0 siblings, 0 replies; 4+ messages in thread
From: Minkyu Kang @ 2013-07-02 6:45 UTC (permalink / raw)
To: u-boot
On 01/07/13 17:41, Rajeshwari Birje wrote:
> Hi Minkyu Kang,
>
> As per the user manual I have for EXYNOS5 it is
> FOUT = MDIV * FIN / (PDIV * 2^SDIV)
What is your version of manual?
If possible, could you please send it to me?
>
> Regards,
> Rajeshwari Shinde.
>
> On Mon, Jul 1, 2013 at 1:56 PM, Minkyu Kang <mk7.kang@samsung.com> wrote:
>> On 01/07/13 16:42, Rajeshwari Shinde wrote:
>>> EXYNOS4 user manual equation for calculating PLL output is
>>> FOUT= MDIV x FIN/(PDIV x 2^(SDIV -1))
>>> hence updating accordingly.
>>>
>>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>>> ---
>>> arch/arm/cpu/armv7/exynos/clock.c | 11 +++++++++--
>>> 1 files changed, 9 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/cpu/armv7/exynos/clock.c b/arch/arm/cpu/armv7/exynos/clock.c
>>> index e1c4246..af0fa5b 100644
>>> --- a/arch/arm/cpu/armv7/exynos/clock.c
>>> +++ b/arch/arm/cpu/armv7/exynos/clock.c
>>> @@ -116,8 +116,15 @@ static int exynos_get_pll_clk(int pllreg, unsigned int r, unsigned int k)
>>> /* FOUT = (MDIV + K / 1024) * FIN / (PDIV * 2^SDIV) */
>>> fout = (m + k / 1024) * (freq / (p * (1 << s)));
>>> } else {
>>> - /* FOUT = MDIV * FIN / (PDIV * 2^SDIV) */
>>> - fout = m * (freq / (p * (1 << s)));
>>> + if (cpu_is_exynos4()) {
>>> + if (s < 1)
>>> + s = 1;
>>> + /* FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1)) */
>>> + fout = m * (freq / (p * (1 << (s - 1))));
>>> + } else {
>>> + /* FOUT = MDIV * FIN / (PDIV * 2^SDIV) */
>>> + fout = m * (freq / (p * (1 << s)));
>>> + }
>>> }
>>>
>>> return fout;
>>>
>>
>> I checked about it.
>> It was wrong, but your patch doesn't fit too.
>>
>> exynos4210
>> FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1))
>>
>> exynos4412
>> FOUT = MDIV * FIN / (PDIV * 2^SDIV)
>>
>> exynos5250
>> FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1))
>>
>> At past, our code was,
>> FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1))
>> It was changed by Akshay's patch.
>>
>>
>> commit 234370cab4b2f096e095fe8f3284fd39740a4023
>> Author: Akshay Saraswat <akshay.s@samsung.com>
>> Date: Fri Mar 22 02:26:36 2013 +0000
>>
>> Exynos5: clock: Update the equation to calculate PLL output frequency
>>
>> According to the latest exynos5 user manual, the equation for
>> calculating PLL output was changed to
>> FOUT= MDIV x FIN/(PDIV x 2^SDIV)
>> earlier it was
>> FOUT= MDIV x FIN/(PDIV x 2^(SDIV -1))
>> So updating the clock code accordingly.
>>
>> Signed-off-by: Hatim Ali <hatim.rv@samsung.com>
>> Signed-off-by: Akshay Saraswat <akshay.s@samsung.com>
>> Acked-by: Simon Glass <sjg@chromium.org>
>>
>>
>> According to Akshay's patch.
>> exynos5250 should be
>> FOUT = MDIV * FIN / (PDIV * 2^SDIV)
>> but my manual (I'm not sure that is latest version) shows
>> FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1))
>>
>> Akshay,
>> please check this.
>>
>> Rajeshwari,
>> Thank you for raise this issue,
>> I'll check it and resend the patch.
>>
>> Thanks,
>> Minkyu Kang.
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>
>
>
Thanks,
Minkyu Kang.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-02 6:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-01 7:42 [U-Boot] [PATCH] Origen: Correct equation to calculate PLL output frequency Rajeshwari Shinde
2013-07-01 8:26 ` Minkyu Kang
2013-07-01 8:41 ` Rajeshwari Birje
2013-07-02 6:45 ` Minkyu Kang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox